Skip to content

Commit 929e02d

Browse files
committed
Do not set CMAKE_BUILD_TYPE for MSVC because it is unused
MSVC is multi-config generator and it needs config type at build time, not generation time. Fixes a warning.
1 parent b5ad951 commit 929e02d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/ci.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131

3232
- name: Build
3333
working-directory: ${{github.workspace}}/build
34-
run: cmake --build . --config $BUILD_TYPE -j $(nproc)
34+
run: cmake --build . -j $(nproc)
3535

3636
build-msvc:
3737
runs-on: windows-latest
@@ -47,7 +47,7 @@ jobs:
4747
working-directory: ${{github.workspace}}/build
4848
run: |
4949
call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvars32.bat"
50-
cmake .. -DCMAKE_BUILD_TYPE=%BUILD_TYPE% -A Win32
50+
cmake .. -A Win32
5151
5252
- name: Build
5353
shell: cmd

0 commit comments

Comments
 (0)