Use default comparisons from C++20

Author: rafalh

common/include/common/utils/list-utils.h

@@ -46,11 +46,6 @@ class SinglyLinkedList
             return current == rhs.current;
         }
 
-        bool operator!=(const self_type& rhs) const
-        {
-            return !(*this == rhs);
-        }
-
         reference operator*() const
         {
             return *current;
@@ -117,15 +112,7 @@ class DoublyLinkedList
             return copy;
         }
 
-        bool operator==(const self_type& rhs) const
-        {
-            return current == rhs.current;
-        }
-
-        bool operator!=(const self_type& rhs) const
-        {
-            return !(*this == rhs);
-        }
+        bool operator==(const self_type& rhs) const = default;
 
         reference operator*() const
         {

editor_patch/mfc_types.h

@@ -31,11 +31,6 @@ struct CString
     {
         return std::strcmp(m_pchData, s) == 0;
     }
-
-    bool operator!=(const char* s) const
-    {
-        return !(*this == s);
-    }
 };
 
 inline HWND WndToHandle(CWnd* wnd)

game_patch/graphics/d3d11/gr_d3d11_dynamic_geometry.h

@@ -39,18 +39,7 @@ namespace df::gr::d3d11
             };
             ID3D11PixelShader* pixel_shader = nullptr;
 
-            bool operator==(const State& other) const
-            {
-                return primitive_topology == other.primitive_topology &&
-                    textures == other.textures &&
-                    mode == other.mode &&
-                    pixel_shader == other.pixel_shader;
-            }
-
-            bool operator!=(const State& other) const
-            {
-                return !(*this == other);
-            }
+            bool operator==(const State& other) const = default;
         };
 
         std::tuple<GpuTransformedVertex*, rf::ushort*, rf::ushort> setup(int num_vert, int num_ind, const State& state)

game_patch/multi/multi_ban.cpp

@@ -23,10 +23,7 @@ class IpRange
         mask_{mask}
     {}
 
-    bool operator==(const IpRange& other)
-    {
-        return ip_ == other.ip_ && mask_ == other.mask_;
-    }
+    bool operator==(const IpRange& other) const = default;
 
     bool matches(unsigned ip)
     {

game_patch/rf/gr/gr.h

@@ -26,15 +26,7 @@ namespace rf::gr
             this->alpha = a;
         }
 
-        bool operator==(const Color& other) const
-        {
-            return red == other.red && green == other.green && blue == other.blue && alpha == other.alpha;
-        }
-
-        bool operator!=(const Color& other) const
-        {
-            return !(*this == other);
-        }
+        bool operator==(const Color& other) const = default;
     };
 
     struct BaseVertex
@@ -141,15 +133,7 @@ namespace rf::gr
             value((ts << ts_shift) | (cs << cs_shift) | (as << as_shift) | (ab << ab_shift) | (zbt << zbt_shift) | (ft << ft_shift))
         {}
 
-        [[nodiscard]] bool operator==(const Mode& other) const
-        {
-            return value == other.value;
-        }
-
-        [[nodiscard]] bool operator!=(const Mode& other) const
-        {
-            return value != other.value;
-        }
+        [[nodiscard]] bool operator==(const Mode& other) const = default;
 
         operator int() const
         {

game_patch/rf/math/matrix.h

@@ -11,15 +11,7 @@ namespace rf
         Vector3 uvec;
         Vector3 fvec;
 
-        bool operator==(const Matrix3& other) const
-        {
-            return rvec == other.rvec && uvec == other.uvec && fvec == other.fvec;
-        }
-
-        bool operator!=(const Matrix3& other) const
-        {
-            return !(*this == other);
-        }
+        bool operator==(const Matrix3& other) const = default;
 
         void make_identity()
         {
@@ -40,15 +32,7 @@ namespace rf
         Matrix3 orient;
         Vector3 origin;
 
-        bool operator==(const Matrix43& other) const
-        {
-            return orient == other.orient && origin == other.origin;
-        }
-
-        bool operator!=(const Matrix43& other) const
-        {
-            return !(*this == other);
-        }
+        bool operator==(const Matrix43& other) const = default;
 
         Matrix43 operator*(const Matrix43& other) const
         {

game_patch/rf/math/vector.h

@@ -14,15 +14,7 @@ namespace rf
         Vector3() = default;
         Vector3(float x, float y, float z) : x(x), y(y), z(z) {}
 
-        bool operator==(const Vector3& other) const
-        {
-            return x == other.x && y == other.y && z == other.z;
-        }
-
-        bool operator!=(const Vector3& other) const
-        {
-            return !(*this == other);
-        }
+        bool operator==(const Vector3& other) const = default;
 
         Vector3& operator+=(const Vector3& other)
         {
@@ -175,15 +167,7 @@ namespace rf
         float x = 0.0f;
         float y = 0.0f;
 
-        bool operator==(const Vector2& other) const
-        {
-            return x == other.x && y == other.y;
-        }
-
-        bool operator!=(const Vector2& other) const
-        {
-            return !(*this == other);
-        }
+        bool operator==(const Vector2& other) const = default;
     };
 
     static auto& vec2_zero_vector = addr_as_ref<Vector2>(0x0173C370);

game_patch/rf/multi.h

@@ -19,15 +19,7 @@ namespace rf
         uint32_t ip_addr;
         uint16_t port;
 
-        bool operator==(const NetAddr &other) const
-        {
-            return ip_addr == other.ip_addr && port == other.port;
-        }
-
-        bool operator!=(const NetAddr &other) const
-        {
-            return !(*this == other);
-        }
+        bool operator==(const NetAddr &other) const = default;
     };
     static_assert(sizeof(NetAddr) == 0x8);
 

game_patch/rf/os/linklist.h

@@ -34,15 +34,7 @@ namespace rf
                 return copy;
             }
 
-            bool operator==(Iterator& other) const
-            {
-                return current_ == other.current_;
-            }
-
-            bool operator!=(Iterator& other) const
-            {
-                return current_ != other.current_;
-            }
+            bool operator==(const Iterator& other) const = default;
         };
 
         class ConstIterator
@@ -70,15 +62,7 @@ namespace rf
                 return copy;
             }
 
-            bool operator==(ConstIterator& other) const
-            {
-                return current_ == other.current_;
-            }
-
-            bool operator!=(ConstIterator& other) const
-            {
-                return current_ != other.current_;
-            }
+            bool operator==(const ConstIterator& other) const = default;
         };
 
         [[nodiscard]] T* first()

patch_common/include/patch_common/AsmWriter.h

@@ -17,10 +17,7 @@ class AsmReg
         reg_num(reg_num), size(size)
     {}
 
-    constexpr bool operator==(const AsmReg& other) const
-    {
-        return reg_num == other.reg_num && size == other.size;
-    }
+    constexpr bool operator==(const AsmReg& other) const = default;
 };
 
 struct AsmReg32 : public AsmReg