Theming

[chrismou]

Need to decide whether we're sticking with the current model (custom made themes) or a more generic theming function (see https://github.com/gmusic-utils/gmusic-theme.js).

Personal preference - implement gmusic-theme for fine grained theming control, but also include some "pre made" theme options, which will essentially just set the gmusic-theme values to whatever (ie, dark grey background, white text and cyan stroke for the "Dark Cyan" theme).

Depends on #3 for somewhere to put the options

[jacobwgillespie]

We should take a look at our existing themes and see if they are possible to recreate with gmusic-theme.js. If so, I say we fully switch, if not, we should PR gmusic-theme.js or create our own extension library.

In general, I'm against pure-css themes, and for having a pure-css override (i.e. the base theme should be defined by JSON / JS, and any complex customization should happen in CSS, IMO).

[chrismou]

Looking at the themes, we can mostly recreate them all using the gmusic-theme functionality.

But as far as end user experience goes, this is my thinking:

• User can select a background, foreground and stroke colour from a colour picker and create their own basic, custom colour schemes (similar to how GPDMP does it)
• We also supply some pre built themes
  • Each theme has it's own directory
  • settings.json controls colour scheme overrides - bacground, foreground and stroke colours
  • Also allows you to specify and include an option CSS file for proper theming - so if you wanted a giant background image for whatever reason, you could

My thinking with the themes is in future we could even potentially create a page in the settings to "upload" a theme into your local Radiant in zip format and have it import the theme, so people can share their creations. Could be interesting.