Make clippy happy

Author: mkuratczyk

src/commands.rs

@@ -129,7 +129,7 @@ pub fn list_policies_in_and_applying_to(
     let policies = client.list_policies_in(vhost)?;
     Ok(policies
         .into_iter()
-        .filter(|pol| apply_to.does_apply_to(pol.apply_to.clone()))
+        .filter(|pol| apply_to.does_apply_to(pol.apply_to))
         .collect())
 }
 
@@ -139,10 +139,10 @@ pub fn list_matching_policies_in(
     name: &str,
     typ: PolicyTarget,
 ) -> ClientResult<Vec<responses::Policy>> {
-    let candidates = list_policies_in_and_applying_to(client, vhost, typ.clone())?;
+    let candidates = list_policies_in_and_applying_to(client, vhost, typ)?;
     Ok(candidates
         .into_iter()
-        .filter(|pol| pol.does_match_name(vhost, name, typ.clone()))
+        .filter(|pol| pol.does_match_name(vhost, name, typ))
         .collect())
 }
 
@@ -165,7 +165,7 @@ pub fn list_operator_policies_in_and_applying_to(
     let policies = client.list_operator_policies_in(vhost)?;
     Ok(policies
         .into_iter()
-        .filter(|pol| apply_to.does_apply_to(pol.apply_to.clone()))
+        .filter(|pol| apply_to.does_apply_to(pol.apply_to))
         .collect())
 }
 
@@ -175,10 +175,10 @@ pub fn list_matching_operator_policies_in(
     name: &str,
     typ: PolicyTarget,
 ) -> ClientResult<Vec<responses::Policy>> {
-    let candidates = list_operator_policies_in_and_applying_to(client, vhost, typ.clone())?;
+    let candidates = list_operator_policies_in_and_applying_to(client, vhost, typ)?;
     Ok(candidates
         .into_iter()
-        .filter(|pol| pol.does_match_name(vhost, name, typ.clone()))
+        .filter(|pol| pol.does_match_name(vhost, name, typ))
         .collect())
 }
 
@@ -1578,7 +1578,7 @@ pub fn declare_policy(
         vhost,
         name,
         pattern,
-        apply_to: apply_to.clone(),
+        apply_to,
         priority: priority.parse::<i32>().unwrap(),
         definition: parsed_definition,
     };
@@ -1606,7 +1606,7 @@ pub fn declare_operator_policy(
         vhost,
         name: &name,
         pattern: &pattern,
-        apply_to: apply_to.clone(),
+        apply_to,
         priority: priority.parse::<i32>().unwrap(),
         definition: parsed_definition,
     };

src/errors.rs

@@ -144,11 +144,10 @@ fn format_client_error(
     status_code: &StatusCode,
     error_details: &Option<rabbitmq_http_client::error::ErrorDetails>,
 ) -> String {
-    if let Some(details) = error_details {
-        if let Some(reason) = details.reason() {
+    if let Some(details) = error_details
+        && let Some(reason) = details.reason() {
             return reason.to_string();
         }
-    }
     format!(
         "API responded with a client error: status code of {}",
         status_code
@@ -159,14 +158,13 @@ fn format_server_error(
     status_code: &StatusCode,
     error_details: &Option<rabbitmq_http_client::error::ErrorDetails>,
 ) -> String {
-    if let Some(details) = error_details {
-        if let Some(reason) = details.reason() {
+    if let Some(details) = error_details
+        && let Some(reason) = details.reason() {
             return format!(
                 "API responded with a server error: status code of {}\n\n{}",
                 status_code, reason
             );
         }
-    }
     format!(
         "API responded with a server error: status code of {}",
         status_code

src/tables.rs

@@ -523,14 +523,13 @@ fn generic_failed_request_details(
         },
     ];
 
-    if let Some(details) = error_details {
-        if let Some(reason) = details.reason() {
+    if let Some(details) = error_details
+        && let Some(reason) = details.reason() {
             data.push(RowOfTwo {
                 key: "error",
                 value: reason,
             });
         }
-    }
 
     build_simple_table(data)
 }