Skip to content

Commit 1f9b1ee

Browse files
Merge pull request #13244 from rabbitmq/ik-shovel_delete_fix
'ctl delete_shovel': adapt to rabbit_shovel_dyn_worker_sup_sup public API changes
2 parents 7117817 + a92a04c commit 1f9b1ee

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

deps/rabbitmq_shovel/src/Elixir.RabbitMQ.CLI.Ctl.Commands.DeleteShovelCommand.erl

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,6 @@ run([Name], #{node := Node, vhost := VHost}) ->
8484
{badrpc, _} = Error ->
8585
Error;
8686
{error, not_found} ->
87-
ErrMsg = rabbit_misc:format("Shovel with the given name was not found "
88-
"on the target node '~ts' and/or virtual host '~ts'. "
89-
"It may be failing to connect and report its state, will delete its runtime parameter...",
90-
[Node, VHost]),
9187
try_force_removing(HostingNode, VHost, Name, ActingUser),
9288
{error, rabbit_data_coercion:to_binary(ErrMsg)};
9389
ok ->
@@ -117,4 +113,4 @@ try_clearing_runtime_parameter(Node, VHost, ShovelName, ActingUser) ->
117113
_ = rabbit_misc:rpc_call(Node, rabbit_runtime_parameters, clear, [VHost, <<"shovel">>, ShovelName, ActingUser]).
118114

119115
try_stopping_child_process(Node, VHost, ShovelName) ->
120-
_ = rabbit_misc:rpc_call(Node, rabbit_shovel_dyn_worker_sup_sup, stop_and_delete_child, [{VHost, ShovelName}]).
116+
_ = rabbit_misc:rpc_call(Node, rabbit_shovel_dyn_worker_sup_sup, stop_child, [{VHost, ShovelName}]).

0 commit comments

Comments
 (0)