Skip to content

Automatic code formatting #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lukebakken opened this issue Apr 8, 2022 · 1 comment · Fixed by #1197
Closed

Automatic code formatting #1192

lukebakken opened this issue Apr 8, 2022 · 1 comment · Fixed by #1197
Assignees
@lukebakken
Milestone
7.0.0

Comments

@lukebakken
Copy link
Collaborator

In #692, @stebet contributed an .editorconfig file that is based on this - https://github.com/dotnet/runtime/blob/main/.editorconfig

In this PR (rabbitmq/rabbitmq-stream-dotnet-client#78) I added the .editorconfig from this project - https://github.com/dotnet/format/blob/main/.editorconfig

We should review the settings in these files and, perhaps, take some other configs into account (https://github.com/dotnet/roslyn/blob/main/.editorconfig)

...then format all the code and add code to the GH actions to verify formatting.

@stebet let me know if you'd like me to wait for #949 updates before running dotnet format on this project.
@lukebakken lukebakken added this to the 7.0.0 milestone Apr 8, 2022
@lukebakken lukebakken self-assigned this Apr 8, 2022
@stebet
Copy link
Contributor

stebet commented Apr 10, 2022

No worries. Go nuts :)

lukebakken added a commit that referenced this issue Apr 18, 2022
@lukebakken
Run "dotnet format"
900479c 
Fixes #1192

Also adds a format check to CI
@lukebakken lukebakken mentioned this issue Apr 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Run "dotnet format" rabbitmq/rabbitmq-dotnet-client
2 participants
@lukebakken @stebet