More code cleanups.

Author: Stefán Jökull Sigurðarson

projects/RabbitMQ.Client/client/impl/SocketFrameHandler.cs

@@ -67,7 +67,7 @@ internal sealed class SocketFrameHandler : IFrameHandler
         private readonly ITcpClient _socket;
 
         // Channels
-        private readonly Channel<ReadOnlyMemory<byte>> _outboundChannel = Channel.CreateUnbounded<ReadOnlyMemory<byte>>(new UnboundedChannelOptions { AllowSynchronousContinuations = false, SingleReader = true, SingleWriter = false });
+        private readonly Channel<ReadOnlyMemory<byte>> _outboundChannel = Channel.CreateUnbounded<ReadOnlyMemory<byte>>(new UnboundedChannelOptions { AllowSynchronousContinuations = true, SingleReader = true, SingleWriter = false });
         private ChannelWriter<ReadOnlyMemory<byte>> OutboundChannelWriter => _outboundChannel.Writer;
         private ChannelReader<ReadOnlyMemory<byte>> OutboundChannelReader => _outboundChannel.Reader;
 
@@ -78,13 +78,10 @@ internal sealed class SocketFrameHandler : IFrameHandler
         private PipeWriter PipeWriter => _pipe.Output;
 
         // Pipe tasks
-        //private Task _writerTask;
+        private readonly Task _writerTask;
 
         private readonly object _semaphore = new object();
         private bool _closed;
-        private readonly object _writeLock = new object();
-
-        private readonly Task _writerTask;
 
         public SocketFrameHandler(AmqpTcpEndpoint endpoint, Func<AddressFamily, ITcpClient> socketFactory, TimeSpan connectionTimeout, TimeSpan readTimeout, TimeSpan writeTimeout)
         {
@@ -125,7 +122,7 @@ public SocketFrameHandler(AmqpTcpEndpoint endpoint, Func<AddressFamily, ITcpClie
             }
 
             _socket.ReceiveTimeout = readTimeout;
-            var pipeOptions = new PipeOptions(useSynchronizationContext: false);
+            var pipeOptions = new PipeOptions(useSynchronizationContext: true);
 
             if (endpoint.Ssl.Enabled)
             {
@@ -146,7 +143,6 @@ public SocketFrameHandler(AmqpTcpEndpoint endpoint, Func<AddressFamily, ITcpClie
 
             WriteTimeout = writeTimeout;
             _writerTask = Task.Run(WriteLoop);
-            //_readerTask = Task.Run(ReadLoop);
         }
         public AmqpTcpEndpoint Endpoint { get; set; }