don't use memory.span if not needed (is a slow operation)

bollhals · bollhals · commit 7717d3143a2e · 2020-05-28T00:35:28.000+02:00
diff --git a/projects/RabbitMQ.Client/client/impl/WireFormatting.cs b/projects/RabbitMQ.Client/client/impl/WireFormatting.cs
@@ -434,8 +434,8 @@ public static int WriteShortstr(Memory<byte> memory, string val)
                 int bytesWritten = Encoding.UTF8.GetBytes(val, 0, val.Length, segment.Array, segment.Offset + 1);
                 if (bytesWritten <= byte.MaxValue)
                 {
-                    memory.Span[0] = (byte)bytesWritten;
-                   return bytesWritten + 1;
+                    segment.Array[segment.Offset] = (byte)bytesWritten;
+                    return bytesWritten + 1;
                 }
 
                 throw new ArgumentOutOfRangeException(nameof(val), val, "Value exceeds the maximum allowed length of 255 bytes.");

Original file line number	Diff line number	Diff line change
`@@ -434,8 +434,8 @@ public static int WriteShortstr(Memory<byte> memory, string val)`
`434`	`434`	`int bytesWritten = Encoding.UTF8.GetBytes(val, 0, val.Length, segment.Array, segment.Offset + 1);`
`435`	`435`	`if (bytesWritten <= byte.MaxValue)`
`436`	`436`	`{`
`437`		`- memory.Span[0] = (byte)bytesWritten;`
`438`		`- return bytesWritten + 1;`
	`437`	`+ segment.Array[segment.Offset] = (byte)bytesWritten;`
	`438`	`+ return bytesWritten + 1;`
`439`	`439`	`}`
`440`	`440`
`441`	`441`	`throw new ArgumentOutOfRangeException(nameof(val), val, "Value exceeds the maximum allowed length of 255 bytes.");`