Some small code cleanups.

Author: Stefán Jökull Sigurðarson

projects/RabbitMQ.Client/client/impl/Connection.Receive.cs

@@ -95,7 +95,12 @@ private async ValueTask MainLoopIteration()
 
                         if (buffer.First.Span[0] == 'A')
                         {
-                            InboundFrame.ProcessProtocolHeader(buffer);
+                            if (buffer.Length >= 8)
+                            {
+                                InboundFrame.ProcessProtocolHeader(buffer);
+                            }
+
+                            throw new EndOfStreamException("Invalid/truncated protocol header.");
                         }
 
                         int framesRead = 0;

projects/RabbitMQ.Client/client/impl/Frame.cs

@@ -32,10 +32,10 @@
 using System;
 using System.Buffers;
 using System.Runtime.CompilerServices;
-using System.Runtime.InteropServices;
 
 using RabbitMQ.Client.Exceptions;
 using RabbitMQ.Client.Framing.Impl;
+using RabbitMQ.Client.Logging;
 using RabbitMQ.Util;
 
 namespace RabbitMQ.Client.Impl
@@ -245,6 +245,7 @@ public static bool TryParseInboundFrame(ref ReadOnlySequence<byte> buffer, out I
             }
 
             buffer = buffer.Slice(frameSize);
+            RabbitMqClientEventSource.Log.DataReceived(frameSize);
             FrameType frameType = (FrameType)payloadBytes[0];
             ushort channel = NetworkOrderDeserializer.ReadUInt16(ref Unsafe.AsRef(payloadBytes[1]));
             frame = new InboundFrame(frameType, channel, payloadBytes.AsMemory(7, payloadSize), payloadBytes);
@@ -256,12 +257,6 @@ private static bool ThrowMalformedFrameException(byte value)
             throw new MalformedFrameException($"Bad frame end marker: {value}");
         }
 
-        internal static InboundFrame ReadFrom(ReadOnlyMemory<byte> frameBytes)
-        {
-            MemoryMarshal.TryGetArray(frameBytes, out ArraySegment<byte> segment);
-            return new InboundFrame((FrameType)frameBytes.Span[0], NetworkOrderDeserializer.ReadUInt16(frameBytes.Span.Slice(1)), frameBytes.Slice(7, frameBytes.Length - 8), segment.Array);
-        }
-
         public byte[] TakeoverPayload()
         {
             return _rentedArray;