Update send_file callback to save a system call #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback is used in RabbitMQ to send the frame header. This commit changes the callback to expect a binary result and to send it along the chunk header. This saves a system call and improves performance with small chunks.
acogoluegnes
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Jul 4, 2025
This saves a system call by sending the frame header and the chunk header at the same time. References rabbitmq/osiris#192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback is used in RabbitMQ to send the frame header. This commit changes the callback to expect a binary result and to send it along the chunk header. This saves a system call and improves performance with small chunks.