Remove aws_eip vpc (default to true) upgrade was provider to 5.0.0 (#28)

* Remove aws_eip vpc (default to true)

* Add pre-commit-hooks

Author: nerahou

.github/workflows/checks.yaml

@@ -0,0 +1,27 @@
+name: Checks
+
+on:
+  push:
+
+env:
+  TFLINT_VERSION: "v0.47.0"
+  TFDOCS_VERSION: "v0.16.0"
+
+jobs:
+  precommit:
+    name: Run precommit-hooks
+    runs-on: ubuntu-latest
+    steps:
+      - name: Install dependencies
+        run: |
+          curl -s https://raw.githubusercontent.com/terraform-linters/tflint/master/install_linux.sh | bash
+          curl -sSLo ./terraform-docs.tar.gz https://terraform-docs.io/dl/v0.16.0/terraform-docs-${TFDOCS_VERSION}-$(uname)-amd64.tar.gz
+          tar -xzf terraform-docs.tar.gz
+          chmod +x terraform-docs
+          sudo mv terraform-docs /usr/bin/terraform-docs
+      - name: Check out code
+        uses: actions/checkout@v3
+
+      - uses: actions/setup-python@v3
+
+      - uses: pre-commit/[email protected]

.gitignore

@@ -27,3 +27,6 @@ override.tf.json
 
 # Include tfplan files to ignore the plan output of command: terraform plan -out=tfplan
 # example: *tfplan*
+
+# Terraform lockfile
+.terraform.lock.hcl

.pre-commit-config.yaml

@@ -0,0 +1,32 @@
+repos:
+  - repo: https://github.com/antonbabenko/pre-commit-terraform
+    rev: v1.82.0
+    hooks:
+      - id: terraform_fmt
+      - id: terraform_validate
+      - id: terraform_docs
+        args:
+          - '--args=--lockfile=false'
+          - '--hook-config=--path-to-file=README.md'
+          - '--hook-config=--create-file-if-not-exist=true'
+      - id: terraform_tflint
+        args:
+          - '--args=--only=terraform_deprecated_interpolation'
+          - '--args=--only=terraform_deprecated_index'
+          - '--args=--only=terraform_unused_declarations'
+          - '--args=--only=terraform_comment_syntax'
+          - '--args=--only=terraform_documented_outputs'
+          - '--args=--only=terraform_documented_variables'
+          - '--args=--only=terraform_typed_variables'
+          - '--args=--only=terraform_module_pinned_source'
+          - '--args=--only=terraform_naming_convention'
+          - '--args=--only=terraform_required_version'
+          - '--args=--only=terraform_required_providers'
+          - '--args=--only=terraform_standard_module_structure'
+          - '--args=--only=terraform_workspace_remote'
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v4.4.0
+    hooks:
+      - id: check-merge-conflict
+      - id: end-of-file-fixer
+      - id: trailing-whitespace

network.tf main.tf

@@ -124,7 +124,7 @@ resource "aws_route_table" "quortex_private" {
 
     content {
       cidr_block     = "0.0.0.0/0"
-      nat_gateway_id = aws_nat_gateway.quortex.0.id
+      nat_gateway_id = aws_nat_gateway.quortex[0].id
     }
   }
 

nat_gateway.tf

@@ -20,8 +20,6 @@
 resource "aws_eip" "quortex" {
   count = (local.enable_nat_gateway && var.nat_eip_allocation_id == "") ? 1 : 0
 
-  vpc = true
-
   tags = merge({ "Name" = var.eip_name }, var.tags)
 }
 
@@ -34,7 +32,7 @@ data "aws_eip" "existing_eip" {
 }
 
 # A single NAT gateway is used for all subnets (NAT gateway is placed in the 1st subnet),
-# or, one NAT gateway in each subnet 
+# or, one NAT gateway in each subnet
 resource "aws_nat_gateway" "quortex" {
   count = local.enable_nat_gateway ? 1 : 0
 

outputs.tf

@@ -41,12 +41,12 @@ EOT
 }
 
 output "route_table_ids_public" {
-  value       = values(aws_route_table.quortex_public).*.id
+  value       = values(aws_route_table.quortex_public)[*].id
   description = "The IDs of the route tables for public subnets"
 }
 
 output "route_table_ids_private" {
-  value       = values(aws_route_table.quortex_private).*.id
+  value       = values(aws_route_table.quortex_private)[*].id
   description = "The IDs of the route tables for private subnets"
 }
 

versions.tf

@@ -18,6 +18,9 @@ terraform {
   required_version = ">= 0.12"
 
   required_providers {
-    aws = ">= 2.38.0"
+    aws = {
+      source  = "hashicorp/aws"
+      version = ">= 2.38.0"
+    }
   }
 }