Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request shorter frame code points before RFC publication #20

Open
marten-seemann opened this issue Aug 20, 2024 · 6 comments
Open

request shorter frame code points before RFC publication #20

marten-seemann opened this issue Aug 20, 2024 · 6 comments

Comments

@marten-seemann
Copy link
Collaborator

A 2-byte code point would be nice.

@huitema
Copy link
Collaborator

huitema commented Aug 24, 2024

I do not really understand the process either. I was expecting some kind of form, but apparently we just need to send an email to the IANA, explaining that we need a code for a transport type and also two consecutive codes for the frame types. If we have to propose values, I would go with 0xAD1 for the "Address Discovery" TP, and 0x0B5A and 0x0B5B for the observed addresses V4 and V6 (OBServed A and OBServed B), but that's just because I like mnemonics.

But I wonder whether we should wait for WG adoption... which my take a bit more time.

@marten-seemann
Copy link
Collaborator Author

I agree. We can always change code points and bump the draft version.

@marten-seemann
Copy link
Collaborator Author

@nibanks had a suggestion for a particular 2-byte code points. Would you mind posting them here?

@nibanks
Copy link
Member

nibanks commented Nov 7, 2024

I started implementing this in msquic and I just shortened what you had to:

    QUIC_FRAME_OBSERVED_ADDRESS_V4  = 0x9f81ULL,
    QUIC_FRAME_OBSERVED_ADDRESS_V6  = 0x9f82ULL,

@huitema
Copy link
Collaborator

huitema commented Nov 7, 2024

@nibanks these numbers are larger than 2^14, and will be encoded on 4 bytes. If we want two bytes, we should use something like:

    QUIC_FRAME_OBSERVED_ADDRESS_V4  = 0x1f81ULL,
    QUIC_FRAME_OBSERVED_ADDRESS_V6  = 0x1f82ULL,

@nibanks
Copy link
Member

nibanks commented Nov 8, 2024

Ah, you're right. I'm fine with those values you suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants