Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet Reception in ACK Frequency Spec example doesnt specify packets received in batch #309

Closed
gaurav2699 opened this issue Dec 23, 2024 · 6 comments · Fixed by #315
Closed

Comments

@gaurav2699
Copy link

The examples provided explains how each packet received would elicit an acknowledgment. However, it does not explicitly mention that packets are not received in batches.
To avoid any potential confusion, I think its worth to add clarification in the specification to state that packets are not received in batches. This would help ensure that the behavior of acknowledgment frequency is clearly understood.

@mirjak
Copy link
Contributor

mirjak commented Jan 27, 2025

I'm not sure if I understand this comment. It really doesn't matter if packets are received in batches or not, because at the end each packet and more importantly each ACK frame contained in a packets needs to be processed. Or can you make a proposal where exactly you would like to see which clarification?

@mirjak
Copy link
Contributor

mirjak commented Jan 27, 2025

Also there is a comment on batch processing (as packets could be received in batches) in section 6.5:

To avoid sending multiple acknowledgments in rapid succession, an
endpoint can process all packets in a batch before determining
whether to send an ACK frame in response, as stated in Section 13.2.2
of [QUIC-TRANSPORT].

@nibanks
Copy link
Member

nibanks commented Jan 27, 2025

@mirjak the issue is that the example assumes you send ACKs immediately after processing individual packets; but if the packets were processed in batch, which as you point out is suggested, the ACKs you send out would actually be different. Overall, it effects the logic of when and what to send, depending on batching.

@mirjak
Copy link
Contributor

mirjak commented Jan 27, 2025

The example assume that the ACK frames are process in the order as given in the example, basically one by one. You mean we should say that explicitly?

@nibanks
Copy link
Member

nibanks commented Jan 27, 2025

Yes, exactly.

@mirjak
Copy link
Contributor

mirjak commented Jan 27, 2025

I created PR #315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants