Skip to content

Commit 22a4da0

Browse files
authored
Merge pull request #314 from quicwg/mirjak-patch-52-1
fix 1-off error in definition and example
2 parents 4ca6ddd + 341a8ac commit 22a4da0

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

draft-ietf-quic-ack-frequency.md

+13-13
Original file line numberDiff line numberDiff line change
@@ -373,13 +373,13 @@ Largest Unacked:
373373
Largest Acked:
374374
: The Largest Acknowledged value sent in an ACK frame.
375375

376-
Largest Reported:
376+
Largest Reported Missing:
377377
: The largest packet number that could be declared lost with the specified
378-
Reordering Threshold, which is Largest Acked - Reordering Threshold + 1.
378+
Reordering Threshold, which is Largest Acked - Reordering Threshold.
379379

380380
Unreported Missing:
381381
: Packets with packet numbers between the Largest Unacked and Largest Reported
382-
that have not yet been received.
382+
Missing that have not yet been received.
383383

384384
An endpoint that receives an ACK_FREQUENCY frame with a non-zero Reordering
385385
Threshold value SHOULD send an immediate ACK when the gap
@@ -403,16 +403,16 @@ and there is a missing packet, an immediate acknowledgement is sent.
403403
If the reordering theshold is 3 and acknowledgements are only sent due to
404404
reordering, the sequence in {{ack-reordering-3}} would occur:
405405

406-
| Received Packet| Largest Unacked| Largest Acked| Largest Reported| Unreported Missing| Send Acknowledgement |
406+
| Received Packet| Largest Unacked| Largest Acked| Largest Reported Missing| Unreported Missing| Send Acknowledgement |
407407
| -- | -- | -- | -- | --- | --- |
408408
| 0 | 0 | - | - | - | No |
409409
| 1 | 1 | - | - | - | No |
410410
| 3 | 3 | - | - | 2 | No |
411411
| 4 | 4 | - | - | 2 | No |
412412
| 5 | 5 | - | - | 2 | Yes (5 - 2 >= 3) |
413-
| 8 | 8 | 5 | 3 | 6,7 | No |
414-
| 9 | 9 | 5 | 3 | 6,7 | Yes (9 - 6 >= 3) |
415-
| 10 | 10 | 9 | 7 | 7 | Yes (10 - 7 >= 3) |
413+
| 8 | 8 | 5 | 2 | 6,7 | No |
414+
| 9 | 9 | 5 | 2 | 6,7 | Yes (9 - 6 >= 3) |
415+
| 10 | 10 | 9 | 6 | 7 | Yes (10 - 7 >= 3) |
416416
{: #ack-reordering-3 title="Acknowledgement behavior with a reordering threshold of 3"}
417417

418418
Note that in this example, the receipt of packet 9 triggers an ACK
@@ -425,27 +425,27 @@ reporting the reception of packet 10.
425425
If the reordering threshold is 5 and acknowledgements are only sent due to
426426
reordering, the sequence in {{ack-reordering-5}} would occur:
427427

428-
| Received Packet| Largest Unacked| Largest Acked| Largest Reported| Unreported Missing| Send Acknowledgement |
428+
| Received Packet| Largest Unacked| Largest Acked| Largest Reported Missing| Unreported Missing| Send Acknowledgement |
429429
| -- | -- | -- | -- | --- | --- |
430430
| 0 | 0 | - | - | - | No |
431431
| 1 | 1 | - | - | - | No |
432432
| 3 | 3 | - | - | 2 | No |
433433
| 5 | 5 | - | - | 2,4 | No |
434434
| 6 | 6 | - | - | 2,4 | No |
435435
| 7 | 7 | - | - | 2,4 | Yes (7 - 2 >= 5)|
436-
| 8 | 8 | 7 | 3 | 4 | No |
437-
| 9 | 9 | 7 | 3 | 4 | Yes (9 - 4 >= 5)|
436+
| 8 | 8 | 7 | 2 | 4 | No |
437+
| 9 | 9 | 7 | 2 | 4 | Yes (9 - 4 >= 5)|
438438
{: #ack-reordering-5 title="Acknowledgement behavior with a reordering threshold of 5"}
439439

440440
## Setting the Reordering Threshold value {#set-threshold}
441441

442442
To ensure timely loss detection, a data sender can send a Reordering Threshold
443-
value of 1 less than the loss detection packet threshold. If the threshold is
443+
value that is the same as the loss detection packet threshold. If the
444+
reordering threshold is
444445
smaller than the packet threshold, an acknowledgement is unnecessarily sent
445446
before the packet can be declared lost. If the value is larger, it can cause
446447
unnecessary delays in loss detection. ({{Section 6.1.1 of QUIC-RECOVERY}})
447-
recommends a default packet threshold for loss detection of 3, equivalent to
448-
a Reordering Threshold of 2.
448+
recommends a default packet threshold for loss detection of 3.
449449

450450
## Expediting Explicit Congestion Notification (ECN) Signals {#congestion}
451451

0 commit comments

Comments
 (0)