Skip to content

Refactor multisearch, fix numeric timestamp unmarshalling #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 19, 2025
Merged

Refactor multisearch, fix numeric timestamp unmarshalling #122

merged 7 commits into from
Jul 19, 2025

Conversation

ddelemeny
Copy link
Collaborator

  • Clean up the client implementation (mostly ExecuteMultisearch and related functions)
  • Use a shallow unmarshal pass to avoid casting timestamps to float64 when not desired
  • Adjust dataframe field creation to handle json.Number
  • Adjust a few tests

Fixes #118

@ddelemeny ddelemeny requested a review from fmassot April 22, 2024 20:53
@fmassot fmassot force-pushed the ddelemeny/refactor-multisearch branch from 9e06f93 to e68dd1f Compare July 19, 2025 05:56
@fmassot fmassot force-pushed the ddelemeny/refactor-multisearch branch from e68dd1f to b28e602 Compare July 19, 2025 06:08
@github-actions GitHub Actions
Copy link

Levitate is-compatible report:

@fmassot fmassot merged commit af7f8a4 into main Jul 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassot fmassot Awaiting requested review from fmassot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multisearch response unmarshalling loses nano precision from numeric timestamps
2 participants
@ddelemeny @fmassot