refactor(fe): simplify Lexer::transaction_has_lex_diagnostics

strager · strager · commit 0549e1cd724e · 2024-08-20T03:00:14.000-04:00
diff --git a/src/quick-lint-js/fe/lex.cpp b/src/quick-lint-js/fe/lex.cpp
@@ -1271,10 +1271,8 @@ void Lexer::roll_back_transaction(Lexer_Transaction&& transaction) {
   this->transaction_allocator_.rewind(std::move(transaction.allocator_rewind));
 }
 
-bool Lexer::transaction_has_lex_diagnostics(const Lexer_Transaction&) const {
-  Buffering_Diag_Reporter* buffered_diagnostics =
-      derived_cast<Buffering_Diag_Reporter*>(this->diag_reporter_);
-  return !buffered_diagnostics->empty();
+bool Lexer::transaction_has_lex_diagnostics(const Lexer_Transaction& transaction) const {
+  return !transaction.reporter->diags().empty();
 }
 
 void Lexer::insert_semicolon() {

Original file line number	Diff line number	Diff line change
`@@ -1271,10 +1271,8 @@ void Lexer::roll_back_transaction(Lexer_Transaction&& transaction) {`
`1271`	`1271`	`this->transaction_allocator_.rewind(std::move(transaction.allocator_rewind));`
`1272`	`1272`	`}`
`1273`	`1273`
`1274`		`-bool Lexer::transaction_has_lex_diagnostics(const Lexer_Transaction&) const {`
`1275`		`- Buffering_Diag_Reporter* buffered_diagnostics =`
`1276`		`- derived_cast<Buffering_Diag_Reporter*>(this->diag_reporter_);`
`1277`		`- return !buffered_diagnostics->empty();`
	`1274`	`+bool Lexer::transaction_has_lex_diagnostics(const Lexer_Transaction& transaction) const {`
	`1275`	`+ return !transaction.reporter->diags().empty();`
`1278`	`1276`	`}`
`1279`	`1277`
`1280`	`1278`	`void Lexer::insert_semicolon() {`