Addressed few offline comments.

Signed-off-by: Meet Patel <[email protected]>

Author: quic-meetkuma

QEfficient/cloud/finetune.py

@@ -86,6 +86,10 @@ def main(**kwargs):
             attn_implementation="sdpa",
             torch_dtype=torch.float16,
         )
+
+        if not hasattr(model, "base_model_prefix"):
+            raise RuntimeError("Given huggingface model does not have 'base_model_prefix' attribute.")
+
         for param in getattr(model, model.base_model_prefix).parameters():
             param.requires_grad = False
 

QEfficient/finetune/utils/train_utils.py

@@ -306,12 +306,8 @@ def train(
                 train_epoch_loss = total_loss / len(train_dataloader)
 
         if train_config.task_type == "seq_classification":
-            accuracy = acc_helper.compute()
+            metric_val = acc_helper.compute()
             acc_helper.reset()
-            if train_config.enable_ddp:
-                dist.all_reduce(accuracy, op=dist.ReduceOp.SUM)
-                accuracy /= dist.get_world_size()
-            metric_val = accuracy
         else:
             metric_val = torch.exp(train_epoch_loss)