Skip to content

Commit 23ca9ca

Browse files
Adding Support for Python3.10 (#141)
* fixing the EOL Signed-off-by: Abukhoyer Shaik <[email protected]> * changing torch to 2.5.0 Signed-off-by: Abukhoyer Shaik <[email protected]> * adding python3.10-venv installation in Jenkins Signed-off-by: Abukhoyer Shaik <[email protected]> * reverting the installation instruction Signed-off-by: Abukhoyer Shaik <[email protected]> * adding python3.10-venv instruction Signed-off-by: Abukhoyer Shaik <[email protected]> * adding python3.10-venv instruction with sudo Signed-off-by: Abukhoyer Shaik <[email protected]> * Update Jenkinsfile Signed-off-by: Amit Raj <[email protected]> * Removing torch=2.5.0 from this PR Signed-off-by: Abukhoyer Shaik <[email protected]> * Fixing Format Signed-off-by: Abukhoyer Shaik <[email protected]> * README updated Signed-off-by: Abukhoyer Shaik <[email protected]> * LF formatted Signed-off-by: Abukhoyer Shaik <[email protected]> --------- Signed-off-by: Abukhoyer Shaik <[email protected]> Signed-off-by: Amit Raj <[email protected]> Co-authored-by: Amit Raj <[email protected]>
1 parent b33197f commit 23ca9ca

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

Dockerfile

+5-5
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ FROM docker-registry.qualcomm.com/library/ubuntu:20.04
77
RUN apt-get update && apt-get install -y \
88
git \
99
tmux \
10-
python3.8 \
11-
python3.8-venv \
10+
python3.10 \
11+
python3.10-venv \
1212
python3-pip
1313

1414
# pip recognizes this variable
@@ -24,7 +24,7 @@ RUN mkdir -p /app/qefficient-library
2424
COPY . /app/qefficient-library
2525

2626
# Create Virtual Env for the docker image
27-
RUN python3.8 -m venv /app/llm_env
27+
RUN python3.10 -m venv /app/llm_env
2828
RUN . /app/llm_env/bin/activate
2929
WORKDIR /app/qefficient-library
3030

@@ -33,7 +33,7 @@ WORKDIR /app/qefficient-library
3333
RUN pip install torch==2.0.0+cpu --extra-index-url https://download.pytorch.org/whl/cpu --no-deps
3434
RUN pip install datasets==2.17.0 fsspec==2023.10.0 multidict==6.0.5 sentencepiece --no-deps
3535

36-
RUN python3.8 -m pip install .
36+
RUN python3.10 -m pip install .
3737
WORKDIR /app/qefficient-library
3838

3939
# Set the environment variable for the model card name and token ID
@@ -45,7 +45,7 @@ ENV TOKEN_ID = ""
4545
# Print a success message
4646
CMD ["echo", "qefficient-transformers repository cloned and setup installed inside Docker image."]
4747
CMD ["echo", "Starting the Model Download and Export to Onnx Stage for QEff."]
48-
CMD python3.8 -m QEfficient.cloud.export --model-name "$MODEL_NAME"
48+
CMD python3.10 -m QEfficient.cloud.export --model-name "$MODEL_NAME"
4949

5050
# Example usage:
5151
# docker build -t qefficient-library .

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@ For other models, there is comprehensive documentation to inspire upon the chang
5959
## Quick Installation
6060
```bash
6161

62-
# Create Python virtual env and activate it. (Recommended Python 3.8)
63-
64-
python3.8 -m venv qeff_env
62+
# Create Python virtual env and activate it. (Recommended Python 3.10)
63+
sudo apt install python3.10-venv
64+
python3.10 -m venv qeff_env
6565
source qeff_env/bin/activate
6666
pip install -U pip
6767

docs/source/upgrade.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
``Warning: Efficient Transformers have been validated to work with the same compatible SDK. Upgrading this may result in certain models becoming incompatible.``
55

66
```bash
7-
# Create Python virtual env and activate it. (Required Python 3.8)
7+
# Create Python virtual env and activate it. (Required Python 3.10)
88

9-
python3.8 -m venv qeff_env
9+
python3.10 -m venv qeff_env
1010
source qeff_env/bin/activate
1111
pip install -U pip
1212

pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ classifiers = [
1414
"Intended Audience :: Developers",
1515
"Intended Audience :: Education",
1616
"Operating System :: Linux",
17-
"Programming Language :: Python :: 3.8",
17+
"Programming Language :: Python :: 3.10",
1818
"Topic :: Scientific/Engineering :: Artificial Intelligence for Inference Accelerator",
1919
]
2020
requires-python = ">=3.8,<3.11"

scripts/Jenkinsfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ pipeline
1616
steps
1717
{
1818
sh '''
19-
python3.8 -m venv preflight_qeff
19+
python3.10 -m venv preflight_qeff
2020
. preflight_qeff/bin/activate
2121
pip install --upgrade pip setuptools
2222
pip install .[test] --extra-index-url https://download.pytorch.org/whl/cpu

0 commit comments

Comments
 (0)