Skip to content

Commit 04be2b1

Browse files
janbritzjanbritz
committed
chore: require Moodle 4.5
1 parent 7ca5729 commit 04be2b1

16 files changed

+39
-35
lines changed

‎.github/workflows/moodle-ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
fail-fast: false
4040
matrix:
4141
php: [ '8.1', '8.2', '8.3' ]
42-
moodle-branch: [ 'MOODLE_404_STABLE' ]
42+
moodle-branch: [ 'MOODLE_405_STABLE' ]
4343
database: [ pgsql, mariadb ]
4444

4545
steps:

‎tests/external/favourite_package_test.php

+1
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ final class favourite_package_test extends \externallib_advanced_testcase {
5050
* This method is called before each test.
5151
*/
5252
public function setUp(): void {
53+
parent::setUp();
5354
$this->resetAfterTest();
5455
$this->setGuestUser();
5556
}

‎tests/external/search_packages_test.php

+1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ final class search_packages_test extends \externallib_advanced_testcase {
5252
* This method is called before each test.
5353
*/
5454
public function setUp(): void {
55+
parent::setUp();
5556
$this->resetAfterTest();
5657
$this->setGuestUser();
5758
}

‎tests/form/elements/html/checkbox.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717
<span id="id_qpy_form_my_checkbox_description">
1818
Right
1919
</span>
20-
<div class="ml-2 d-flex align-items-center align-self-start">
20+
<div class="ms-2 d-flex align-items-center align-self-start">
2121
<div class="text-danger" title="Required">
22-
<i class="icon fa fa-exclamation-circle text-danger fa-fw " title="Required" role="img" aria-label="Required"></i>
22+
<i class="icon fa fa-circle-exclamation text-danger fa-fw " title="Required" role="img" aria-label="Required"></i>
2323
</div>
2424
<a class="btn btn-link p-0" role="button" data-container="body" data-toggle="popover" data-placement="right" data-content="Help text " data-html="true" tabindex="0" data-trigger="focus" aria-label="Help">
25-
<i class="icon fa fa-question-circle text-info fa-fw " title="Help with Left" role="img" aria-label="Help with Left"></i>
25+
<i class="icon fa fa-circle-question text-info fa-fw " title="Help with Left" role="img" aria-label="Help with Left"></i>
2626
</a>
2727
</div>
2828
</div>
@@ -31,5 +31,5 @@
3131
</div>
3232
</div>
3333
</div>
34-
<div class="fdescription required"><i class="icon fa fa-exclamation-circle text-danger fa-fw " title="Required field" role="img" aria-label="Required field"></i> Required</div>
34+
<div class="fdescription required"><i class="icon fa fa-circle-exclamation text-danger fa-fw " title="Required field" role="img" aria-label="Required field"></i> Required</div>
3535
</form></body></html>

‎tests/form/elements/html/checkbox_group.html

+5-5
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@
1818
<span id="id_qpy_form_my_checkbox_description">
1919
Right
2020
</span>
21-
<div class="ml-2 d-flex align-items-center align-self-start">
21+
<div class="ms-2 d-flex align-items-center align-self-start">
2222
<div class="text-danger" title="Required">
23-
<i class="icon fa fa-exclamation-circle text-danger fa-fw " title="Required" role="img" aria-label="Required"></i>
23+
<i class="icon fa fa-circle-exclamation text-danger fa-fw " title="Required" role="img" aria-label="Required"></i>
2424
</div>
2525
<a class="btn btn-link p-0" role="button" data-container="body" data-toggle="popover" data-placement="right" data-content="Help text " data-html="true" tabindex="0" data-trigger="focus" aria-label="Help">
26-
<i class="icon fa fa-question-circle text-info fa-fw " title="Help with Left" role="img" aria-label="Help with Left"></i>
26+
<i class="icon fa fa-circle-question text-info fa-fw " title="Help with Left" role="img" aria-label="Help with Left"></i>
2727
</a>
2828
</div>
2929
</div>
@@ -32,7 +32,7 @@
3232
</div>
3333
</div>
3434
</div><div id="fitem_id_nosubmit_checkbox_controller1" class="mb-3 row fitem femptylabel ">
35-
<div class="col-md-3 col-form-label d-flex pb-0 pr-md-0">
35+
<div class="col-md-3 col-form-label d-flex pb-0 pe-md-0">
3636

3737
<div class="form-label-addon d-flex align-items-center align-self-start">
3838

@@ -50,5 +50,5 @@
5050
</div>
5151
</div>
5252
</div>
53-
<div class="fdescription required"><i class="icon fa fa-exclamation-circle text-danger fa-fw " title="Required field" role="img" aria-label="Required field"></i> Required</div>
53+
<div class="fdescription required"><i class="icon fa fa-circle-exclamation text-danger fa-fw " title="Required field" role="img" aria-label="Required field"></i> Required</div>
5454
</form></body></html>

‎tests/form/elements/html/group.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
</div>
66

77
<div id="fgroup_id_qpy_form_my_group" class="mb-3 row fitem " data-groupname="qpy_form[my_group]">
8-
<div class="col-md-3 col-form-label d-flex pb-0 pr-md-0">
8+
<div class="col-md-3 col-form-label d-flex pb-0 pe-md-0">
99
<p id="fgroup_id_qpy_form_my_group_label" class="mb-0 word-break" aria-hidden="true">
1010
Name
1111
</p>
1212

1313
<div class="form-label-addon d-flex align-items-center align-self-start">
1414
<a class="btn btn-link p-0" role="button" data-container="body" data-toggle="popover" data-placement="right" data-content="Help text " data-html="true" tabindex="0" data-trigger="focus" aria-label="Help">
15-
<i class="icon fa fa-question-circle text-info fa-fw " title="Help with Name" role="img" aria-label="Help with Name"></i>
15+
<i class="icon fa fa-circle-question text-info fa-fw " title="Help with Name" role="img" aria-label="Help with Name"></i>
1616
</a>
1717
</div>
1818
</div>
@@ -45,5 +45,5 @@
4545
</div>
4646
</div>
4747
</div>
48-
<div class="fdescription required"><i class="icon fa fa-exclamation-circle text-danger fa-fw " title="Required field" role="img" aria-label="Required field"></i> Required</div>
48+
<div class="fdescription required"><i class="icon fa fa-circle-exclamation text-danger fa-fw " title="Required field" role="img" aria-label="Required field"></i> Required</div>
4949
</form></body></html>

‎tests/form/elements/html/input.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
</div>
66

77
<div id="fitem_id_qpy_form_my_field" class="mb-3 row fitem ">
8-
<div class="col-md-3 col-form-label d-flex pb-0 pr-md-0">
8+
<div class="col-md-3 col-form-label d-flex pb-0 pe-md-0">
99

1010
<label id="id_qpy_form_my_field_label" class="d-inline word-break " for="id_qpy_form_my_field">
1111
Label
1212
</label>
1313

1414
<div class="form-label-addon d-flex align-items-center align-self-start">
1515
<div class="text-danger" title="Required">
16-
<i class="icon fa fa-exclamation-circle text-danger fa-fw " title="Required" role="img" aria-label="Required"></i>
16+
<i class="icon fa fa-circle-exclamation text-danger fa-fw " title="Required" role="img" aria-label="Required"></i>
1717
</div>
1818

1919
</div>
@@ -25,5 +25,5 @@
2525
</div>
2626
</div>
2727
</div>
28-
<div class="fdescription required"><i class="icon fa fa-exclamation-circle text-danger fa-fw " title="Required field" role="img" aria-label="Required field"></i> Required</div>
28+
<div class="fdescription required"><i class="icon fa fa-circle-exclamation text-danger fa-fw " title="Required field" role="img" aria-label="Required field"></i> Required</div>
2929
</form></body></html>

‎tests/form/elements/html/radio_group.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
</div>
66

77
<div id="fgroup_id_qpy_form_radio_group_my_radio" class="mb-3 row fitem " data-groupname="qpy_form[radio_group_my_radio]">
8-
<div class="col-md-3 col-form-label d-flex pb-0 pr-md-0">
8+
<div class="col-md-3 col-form-label d-flex pb-0 pe-md-0">
99
<p id="fgroup_id_qpy_form_radio_group_my_radio_label" class="mb-0 word-break" aria-hidden="true">
1010
Label
1111
</p>
1212

1313
<div class="form-label-addon d-flex align-items-center align-self-start">
1414
<div class="text-danger" title="Required">
15-
<i class="icon fa fa-exclamation-circle text-danger fa-fw " title="Required" role="img" aria-label="Required"></i>
15+
<i class="icon fa fa-circle-exclamation text-danger fa-fw " title="Required" role="img" aria-label="Required"></i>
1616
</div>
1717

1818
</div>
@@ -48,5 +48,5 @@
4848
</div>
4949
</div>
5050
</div>
51-
<div class="fdescription required"><i class="icon fa fa-exclamation-circle text-danger fa-fw " title="Required field" role="img" aria-label="Required field"></i> Required</div>
51+
<div class="fdescription required"><i class="icon fa fa-circle-exclamation text-danger fa-fw " title="Required field" role="img" aria-label="Required field"></i> Required</div>
5252
</form></body></html>

‎tests/form/elements/html/repetition.html

+7-7
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
</div>
77

88
<div class="qpy-repetition"><div class="qpy-repetition-content"><div id="fitem_id_qpy_form_my_rep_0_item" class="mb-3 row fitem ">
9-
<div class="col-md-3 col-form-label d-flex pb-0 pr-md-0">
9+
<div class="col-md-3 col-form-label d-flex pb-0 pe-md-0">
1010

1111
<label id="id_qpy_form_my_rep_0_item_label" class="d-inline word-break " for="id_qpy_form_my_rep_0_item">
1212
Label
@@ -22,8 +22,8 @@
2222

2323
</div>
2424
</div>
25-
</div></div><div class="qpy-repetition-controls"><button name="qpy_repetition[qpy_form_my_rep_][remove][0]" type="submit" class="btn btn-secondary qpy-repetition-remove" value="remove"><i class="icon fa fa-trash fa-fw " title="Remove" role="img" aria-label="Remove"></i> Remove</button></div></div><div class="qpy-repetition"><div class="qpy-repetition-content"><div id="fitem_id_qpy_form_my_rep_1_item" class="mb-3 row fitem ">
26-
<div class="col-md-3 col-form-label d-flex pb-0 pr-md-0">
25+
</div></div><div class="qpy-repetition-controls"><button name="qpy_repetition[qpy_form_my_rep_][remove][0]" type="submit" class="btn btn-secondary qpy-repetition-remove" value="remove"><i class="icon fa fa-trash-can fa-fw " title="Remove" role="img" aria-label="Remove"></i> Remove</button></div></div><div class="qpy-repetition"><div class="qpy-repetition-content"><div id="fitem_id_qpy_form_my_rep_1_item" class="mb-3 row fitem ">
26+
<div class="col-md-3 col-form-label d-flex pb-0 pe-md-0">
2727

2828
<label id="id_qpy_form_my_rep_1_item_label" class="d-inline word-break " for="id_qpy_form_my_rep_1_item">
2929
Label
@@ -39,8 +39,8 @@
3939

4040
</div>
4141
</div>
42-
</div></div><div class="qpy-repetition-controls"><button name="qpy_repetition[qpy_form_my_rep_][remove][1]" type="submit" class="btn btn-secondary qpy-repetition-remove" value="remove"><i class="icon fa fa-trash fa-fw " title="Remove" role="img" aria-label="Remove"></i> Remove</button></div></div><div class="qpy-repetition"><div class="qpy-repetition-content"><div id="fitem_id_qpy_form_my_rep_2_item" class="mb-3 row fitem ">
43-
<div class="col-md-3 col-form-label d-flex pb-0 pr-md-0">
42+
</div></div><div class="qpy-repetition-controls"><button name="qpy_repetition[qpy_form_my_rep_][remove][1]" type="submit" class="btn btn-secondary qpy-repetition-remove" value="remove"><i class="icon fa fa-trash-can fa-fw " title="Remove" role="img" aria-label="Remove"></i> Remove</button></div></div><div class="qpy-repetition"><div class="qpy-repetition-content"><div id="fitem_id_qpy_form_my_rep_2_item" class="mb-3 row fitem ">
43+
<div class="col-md-3 col-form-label d-flex pb-0 pe-md-0">
4444

4545
<label id="id_qpy_form_my_rep_2_item_label" class="d-inline word-break " for="id_qpy_form_my_rep_2_item">
4646
Label
@@ -56,8 +56,8 @@
5656

5757
</div>
5858
</div>
59-
</div></div><div class="qpy-repetition-controls"><button name="qpy_repetition[qpy_form_my_rep_][remove][2]" type="submit" class="btn btn-secondary qpy-repetition-remove" value="remove"><i class="icon fa fa-trash fa-fw " title="Remove" role="img" aria-label="Remove"></i> Remove</button></div></div><div id="fitem_id_qpy_repetition_qpy_form_my_rep__add_more" class="mb-3 row fitem femptylabel ">
60-
<div class="col-md-3 col-form-label d-flex pb-0 pr-md-0">
59+
</div></div><div class="qpy-repetition-controls"><button name="qpy_repetition[qpy_form_my_rep_][remove][2]" type="submit" class="btn btn-secondary qpy-repetition-remove" value="remove"><i class="icon fa fa-trash-can fa-fw " title="Remove" role="img" aria-label="Remove"></i> Remove</button></div></div><div id="fitem_id_qpy_repetition_qpy_form_my_rep__add_more" class="mb-3 row fitem femptylabel ">
60+
<div class="col-md-3 col-form-label d-flex pb-0 pe-md-0">
6161

6262
<div class="form-label-addon d-flex align-items-center align-self-start">
6363

‎tests/form/elements/html/select.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
</div>
66

77
<div id="fitem_id_qpy_form_my_select" class="mb-3 row fitem ">
8-
<div class="col-md-3 col-form-label d-flex pb-0 pr-md-0">
8+
<div class="col-md-3 col-form-label d-flex pb-0 pe-md-0">
99

1010
<label id="id_qpy_form_my_select_label" class="d-inline word-break " for="id_qpy_form_my_select">
1111
Label
1212
</label>
1313

1414
<div class="form-label-addon d-flex align-items-center align-self-start">
1515
<div class="text-danger" title="Required">
16-
<i class="icon fa fa-exclamation-circle text-danger fa-fw " title="Required" role="img" aria-label="Required"></i>
16+
<i class="icon fa fa-circle-exclamation text-danger fa-fw " title="Required" role="img" aria-label="Required"></i>
1717
</div>
1818

1919
</div>
@@ -31,5 +31,5 @@
3131
</div>
3232
</div>
3333
</div>
34-
<div class="fdescription required"><i class="icon fa fa-exclamation-circle text-danger fa-fw " title="Required field" role="img" aria-label="Required field"></i> Required</div>
34+
<div class="fdescription required"><i class="icon fa fa-circle-exclamation text-danger fa-fw " title="Required field" role="img" aria-label="Required field"></i> Required</div>
3535
</form></body></html>

‎tests/form/elements/html/static_text.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
</div>
66

77
<div id="fitem_id_qpy_form_my_text" class="mb-3 row fitem ">
8-
<div class="col-md-3 col-form-label d-flex pb-0 pr-md-0">
8+
<div class="col-md-3 col-form-label d-flex pb-0 pe-md-0">
99

1010
<span class="d-inline-block ">
1111
Label

‎tests/form/elements/html/textarea.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
</div>
66

77
<div id="fitem_id_qpy_form_my_field" class="mb-3 row fitem ">
8-
<div class="col-md-3 col-form-label d-flex pb-0 pr-md-0">
8+
<div class="col-md-3 col-form-label d-flex pb-0 pe-md-0">
99

1010
<label id="id_qpy_form_my_field_label" class="d-inline word-break " for="id_qpy_form_my_field">
1111
Label
1212
</label>
1313

1414
<div class="form-label-addon d-flex align-items-center align-self-start">
1515
<div class="text-danger" title="Required">
16-
<i class="icon fa fa-exclamation-circle text-danger fa-fw " title="Required" role="img" aria-label="Required"></i>
16+
<i class="icon fa fa-circle-exclamation text-danger fa-fw " title="Required" role="img" aria-label="Required"></i>
1717
</div>
1818

1919
</div>
@@ -25,5 +25,5 @@
2525
</div>
2626
</div>
2727
</div>
28-
<div class="fdescription required"><i class="icon fa fa-exclamation-circle text-danger fa-fw " title="Required field" role="img" aria-label="Required field"></i> Required</div>
28+
<div class="fdescription required"><i class="icon fa fa-circle-exclamation text-danger fa-fw " title="Required field" role="img" aria-label="Required field"></i> Required</div>
2929
</form></body></html>

‎tests/question_service_test.php

+1
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ final class question_service_test extends \advanced_testcase {
5050
private question_service $questionservice;
5151

5252
protected function setUp(): void {
53+
parent::setUp();
5354
$this->resetAfterTest();
5455
$this->api = $this->createMock(api::class);
5556
$this->packageapi = $this->createMock(package_api::class);

‎tests/question_test.php

+1
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ final class question_test extends \advanced_testcase {
5656
* @throws moodle_exception
5757
*/
5858
protected function setUp(): void {
59+
parent::setUp();
5960
$this->resetAfterTest();
6061

6162
// Load questionpy.

‎tests/static_file_service_test.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
use invalid_dataroot_permissions;
3434
use moodle_exception;
3535
use qtype_questionpy\api\api;
36-
use qtype_questionpy\api\package_api;
3736
use qtype_questionpy\api\qpy_http_client;
3837

3938
/**
@@ -67,6 +66,7 @@ final class static_file_service_test extends \advanced_testcase {
6766
* @throws dml_exception
6867
*/
6968
protected function setUp(): void {
69+
parent::setUp();
7070
$this->mockhandler = new MockHandler();
7171
$this->requesthistory = [];
7272
$handlerstack = HandlerStack::create($this->mockhandler);

‎version.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626

2727
$plugin->component = 'qtype_questionpy';
2828
$plugin->version = 2024101700;
29-
$plugin->requires = 2024042200;
29+
$plugin->requires = 2024100700;
3030
$plugin->maturity = MATURITY_ALPHA;
3131
$plugin->release = '0.1';
3232

0 commit comments

Comments
 (0)