-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to TypeScript #64
Comments
This would be useful so other devs don't need to define files like https://github.com/Archomeda/gw2-console/blob/master/types/gw2api-client.d.ts |
I am currently working on a migration, but obviously, the process is quite cumbersome as defining all possible response types takes a lot of time. What's the scope of this issue? Just a basic migration with several result types available and some possible still being |
Yeah, I tried auto-generating some types before as well, but the quality of those was pretty meh.
I think the goal is definitely full type support with all types. But I'd be more than happy to merge a PR with some types, it doesnt have to be all of them. 👍 Maybe even start with something small, so we can align the style. |
Okay, I'll just poke a bit around and see how far I can get. It may actually require slight adjustments in the API if you'd like to have the types as strict as possible, as the rolling schema version is hard to express via types. |
Any update on this @ogrady @queicherius ? |
Hi everyone, I defined most endpoints manually in my fork, but then got swamped with other projects and irl stuff. I hope to continue at some point, maybe around the holidays, but there is still a truckload of work to do. tl;dr: I have made good progress but had to pause. |
To anyone watching out for this one, I talked with @ogrady for a bit today and I'm going to take this issue over from the state of the latest commit on the open PR to try to wrap up the rest of it over the next few weeks (time permitting of course). |
No description provided.
The text was updated successfully, but these errors were encountered: