Skip to content

brand is not applied to dark mode if dark mode is enabled by theme #12981

Open
@gordonwoodhull

Description

@gordonwoodhull

The following should have blue text in both light and dark mode, but in 1.7 it doesn't because this doesn't have a dark brand.

---
title: Blue text, theme enables dark mode
format:
  dashboard: default
theme:
  light: default
  dark: darkly
brand:
  color:
    foreground: '#12b'
---

{{< lipsum 4 >}}

You would have to also enable dark brand, because dark brand and dark themes are activated independently:

theme:
  light: default
  dark: darkly
brand:
  light:
    color:
      foreground: '#12b'
  dark:
    color:
      foreground: '#12b'

When implementing unified light and dark brand #12797 and doing thorough testing of dark logo, I noticed this inconsistency. I will take care of it as part of dark logo.

I don't think it's worth a backport since it's not a regression, and it's easy to work around. But I'm open to the idea, since it's a glaring bug and may surprise users who already had dark themes and are trying out brand.yml.

Metadata

Metadata

Labels

brand`_brand.yml`bugSomething isn't workingthemesRelated to HTML theming or any other style related issue (like highlight-style)

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions