Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Default value for OTEL_SERVICE_NAME #276

Open
amoscatelli opened this issue May 10, 2023 · 3 comments
Open

Feature Request - Default value for OTEL_SERVICE_NAME #276

amoscatelli opened this issue May 10, 2023 · 3 comments

Comments

@amoscatelli
Copy link

When using otel registry, OTEL_SERVICE_NAME should fall back to application name, if not provided in any other means.

If I don't specify OTEL_SERVICE_NAME I see this in NewRelic :

image

Instead I think this should behave like described in opentelemetry quarkus integration :
https://quarkus.io/guides/opentelemetry

image

What do you think ?

@amoscatelli
Copy link
Author

amoscatelli commented May 10, 2023

Here :

* Defaults to empty. If not set it tries to use OTEL_RESOURCE_ATTRIBUTES and OTEL_SERVICE_NAME to automatically

But if OTEL_SERVICE_NAME is not set, it should fall back to ${quarkus.application.name}

@amoscatelli
Copy link
Author

@ebullient if you agree I can make a PR about this ...

Let me know
Thank you

@ebullient
Copy link
Contributor

PRs are always welcome. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants