Fix flake8-warnings in signals tests

Pick-to: 6.7
Task-number: PYSIDE-2646
Change-Id: I4f6b5d642f540fb3f5f2e219057c862fe5998a21
Reviewed-by: Qt CI Bot <[email protected]>
Reviewed-by: Cristian Maureira-Fredes <[email protected]>

Author: FriedemannKleint

.flake8

@@ -6,5 +6,7 @@ per-file-ignores =
     # for init_test_paths() hack
     *_test_*.py:E402
     *_test.py:E402
+    *bug_*.py:E402
     test_*.py:E402
+    signal_across_threads.py:E402
     __init__.py:F401,E402

sources/pyside6/tests/signals/bug_311.py

@@ -52,4 +52,3 @@ def testBug(self):
 
 if __name__ == '__main__':
     unittest.main()
-

sources/pyside6/tests/signals/bug_312.py

@@ -58,5 +58,3 @@ def testDisconnectCleanup(self):
 
 if __name__ == '__main__':
     unittest.main()
-
-

sources/pyside6/tests/signals/bug_319.py

@@ -45,4 +45,3 @@ def testBug(self):
 
 if __name__ == '__main__':
     unittest.main()
-

sources/pyside6/tests/signals/bug_79.py

@@ -30,7 +30,7 @@ def callback(self, o):
 
     def testNoLeaks_ConnectAndDisconnect(self):
         self._called = None
-        app = QApplication([])
+        app = QApplication([])  # noqa: F841
         o = QTreeView()
         o.setModel(QStandardItemModel())
         o.selectionModel().destroyed.connect(self.callback)

sources/pyside6/tests/signals/invalid_callback_test.py

@@ -40,4 +40,3 @@ def testIntegerCb(self):
 
 if __name__ == '__main__':
     unittest.main()
-

sources/pyside6/tests/signals/lambda_gui_test.py

@@ -33,7 +33,7 @@ def testButton(self):
             # Connecting a lambda to a QPushButton.clicked()
             obj = QPushButton('label')
             ctr = Control()
-            func = lambda: setattr(ctr, 'arg', True)
+            func = lambda: setattr(ctr, 'arg', True)  # noqa: E731
             obj.clicked.connect(func)
             obj.click()
             self.assertTrue(ctr.arg)
@@ -44,7 +44,7 @@ def testSpinButton(self):
             obj = QSpinBox()
             ctr = Control()
             arg = 444
-            func = lambda x: setattr(ctr, 'arg', 444)
+            func = lambda x: setattr(ctr, 'arg', 444)  # noqa: E731
             obj.valueChanged.connect(func)
             obj.setValue(444)
             self.assertEqual(ctr.arg, arg)

sources/pyside6/tests/signals/leaking_signal_test.py

@@ -4,7 +4,6 @@
 import os
 import sys
 import unittest
-import weakref
 
 from pathlib import Path
 sys.path.append(os.fspath(Path(__file__).resolve().parents[1]))
@@ -21,7 +20,7 @@ def testLeakingSignal(self):
         class Emitter(QObject):
             my_signal = Signal(object)
 
-        emitter = Emitter()
+        emitter = Emitter()  # noqa: F841
 
 
 if __name__ == '__main__':

sources/pyside6/tests/signals/multiple_connections_gui_test.py

@@ -1,9 +1,7 @@
 # Copyright (C) 2022 The Qt Company Ltd.
 # SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
 
-from functools import partial
 import os
-import random
 import sys
 import unittest
 

sources/pyside6/tests/signals/pysignal_test.py

@@ -14,7 +14,7 @@
 from PySide6.QtCore import QObject, SIGNAL, SLOT, Qt
 
 try:
-    from PySide6.QtWidgets import QSpinBox, QApplication, QWidget
+    from PySide6.QtWidgets import QSpinBox, QApplication, QWidget  # noqa: F401
     hasQtGui = True
 except ImportError:
     hasQtGui = False
@@ -97,7 +97,7 @@ def setUp(self):
     def tearDown(self):
         try:
             del self.args
-        except:
+        except:  # noqa: E722
             pass
         # PYSIDE-535: Need to collect garbage in PyPy to trigger deletion
         gc.collect()

sources/pyside6/tests/signals/qobject_destroyed_test.py

@@ -11,7 +11,7 @@
 from init_paths import init_test_paths
 init_test_paths(False)
 
-from PySide6.QtCore import QObject, SIGNAL
+from PySide6.QtCore import QObject
 
 
 class QObjectDestroyed(unittest.TestCase):

sources/pyside6/tests/signals/ref01_test.py

@@ -37,5 +37,3 @@ def testBoundSignal(self):
 
 if __name__ == '__main__':
     unittest.main()
-
-

sources/pyside6/tests/signals/ref02_test.py

@@ -12,7 +12,7 @@
 from init_paths import init_test_paths
 init_test_paths(False)
 
-from PySide6.QtCore import QCoreApplication, QTimeLine
+from PySide6.QtCore import QTimeLine
 from helper.usesqapplication import UsesQApplication
 
 
@@ -58,4 +58,3 @@ def finishedSlot():
 
 if __name__ == '__main__':
     unittest.main()
-

sources/pyside6/tests/signals/ref03_test.py

@@ -40,4 +40,3 @@ def destroyedSlot():
 
 if __name__ == '__main__':
     unittest.main()
-

sources/pyside6/tests/signals/ref04_test.py

@@ -53,17 +53,6 @@ def slot():
         self.emitter.mySignal.emit()
         self.assertEqual(self.counter, 2)
 
-#    def testConnectWithConfigureMethod(self):
-#
-#        def slot():
-#            self.counter += 1
-#
-#        self.emitter.pyqtConfigure(mySignal=slot)
-#        self.assertEqual(self.counter, 0)
-#        self.emitter.mySignal.emit()
-#        self.assertEqual(self.counter, 1)
-
 
 if __name__ == '__main__':
     unittest.main()
-

sources/pyside6/tests/signals/ref05_test.py

@@ -12,7 +12,7 @@
 from init_paths import init_test_paths
 init_test_paths(False)
 
-from PySide6.QtCore import QObject, QCoreApplication, QTimeLine, Slot
+from PySide6.QtCore import QObject, QTimeLine, Slot
 from helper.usesqapplication import UsesQApplication
 
 
@@ -56,4 +56,3 @@ def testUserSlot(self):
 
 if __name__ == '__main__':
     unittest.main()
-

sources/pyside6/tests/signals/ref06_test.py

@@ -12,7 +12,7 @@
 from init_paths import init_test_paths
 init_test_paths(False)
 
-from PySide6.QtCore import QObject, QCoreApplication, QTimeLine, Signal, Slot
+from PySide6.QtCore import QObject, QTimeLine, Signal, Slot
 from helper.usesqapplication import UsesQApplication
 
 
@@ -59,4 +59,3 @@ def testSignaltoSignal(self):
 
 if __name__ == '__main__':
     unittest.main()
-

sources/pyside6/tests/signals/segfault_proxyparent_test.py

@@ -44,7 +44,7 @@ def setUp(self):
     def tearDown(self):
         try:
             del self.args
-        except:
+        except:  # noqa: E722
             pass
         # PYSIDE-535: Need to collect garbage in PyPy to trigger deletion
         gc.collect()
@@ -73,4 +73,3 @@ def testSegfault(self):
 
 if __name__ == '__main__':
     unittest.main()
-

sources/pyside6/tests/signals/self_connect_test.py

@@ -13,9 +13,8 @@
 from init_paths import init_test_paths
 init_test_paths(False)
 
-from PySide6.QtCore import QObject, SIGNAL, SLOT
+from PySide6.QtCore import QObject, Slot, SIGNAL, SLOT
 from PySide6.QtWidgets import QPushButton, QWidget
-from PySide6.QtCore import QObject, Slot
 
 from helper.usesqapplication import UsesQApplication
 
@@ -25,7 +24,7 @@ def __init__(self, p=None):
         super().__init__(p)
         self.triggered = False
 
-    @Slot(bool,int)
+    @Slot(bool, int)
     def default_parameter_slot(self, bool_value, int_value=0):
         self.triggered = True
 

sources/pyside6/tests/signals/short_circuit_test.py

@@ -11,7 +11,7 @@
 from init_paths import init_test_paths
 init_test_paths(False)
 
-from PySide6.QtCore import QObject, SIGNAL, SLOT
+from PySide6.QtCore import QObject, SIGNAL
 
 
 class Dummy(QObject):
@@ -27,7 +27,7 @@ def setUp(self):
     def tearDown(self):
         try:
             del self.args
-        except:
+        except:  # noqa: E722
             pass
         # PYSIDE-535: Need to collect garbage in PyPy to trigger deletion
         gc.collect()

sources/pyside6/tests/signals/signal2signal_connect_test.py

@@ -34,11 +34,11 @@ def tearDown(self):
         # Delete used resources
         try:
             del self.sender
-        except:
+        except:  # noqa: E722
             pass
         try:
             del self.forwarder
-        except:
+        except:  # noqa: E722
             pass
         del self.args
         # PYSIDE-535: Need to collect garbage in PyPy to trigger deletion
@@ -116,5 +116,3 @@ def testSignalWithOneQObjectArgument(self):
 
 if __name__ == '__main__':
     unittest.main()
-
-

sources/pyside6/tests/signals/signal_autoconnect_test.py

@@ -27,7 +27,7 @@ def on_button_clicked(self):
 class AutoConnectionTest(unittest.TestCase):
 
     def testConnection(self):
-        app = QApplication([])
+        app = QApplication([])  # noqa: F841
 
         win = MyObject()
         btn = QPushButton("click", win)

sources/pyside6/tests/signals/signal_emission_gui_test.py

@@ -14,7 +14,7 @@
 from init_paths import init_test_paths
 init_test_paths(False)
 
-from PySide6.QtCore import QObject, SIGNAL, SLOT
+from PySide6.QtCore import SIGNAL
 
 try:
     from PySide6.QtWidgets import QSpinBox, QPushButton

sources/pyside6/tests/signals/signal_emission_test.py

@@ -16,7 +16,6 @@
 
 from PySide6.QtCore import QObject, SIGNAL, SLOT, QProcess, QTimeLine
 
-from helper.basicpyslotcase import BasicPySlotCase
 from helper.usesqapplication import UsesQApplication
 
 

sources/pyside6/tests/signals/signal_manager_refcount_test.py

@@ -16,7 +16,8 @@
 
 
 class SignalManagerRefCount(unittest.TestCase):
-    """Simple test case to check if the signal_manager is erroneously incrementing the object refcounter"""
+    """Simple test case to check if the signal_manager is erroneously incrementing the
+       object refcounter."""
 
     @unittest.skipUnless(hasattr(sys, "getrefcount"), f"{sys.implementation.name} has no refcount")
     def testObjectRefcount(self):
@@ -33,4 +34,3 @@ def callback():
 
 if __name__ == '__main__':
     unittest.main()
-

sources/pyside6/tests/signals/signal_signature_test.py

@@ -99,4 +99,3 @@ def testLambdaSlot(self):
 
 if __name__ == '__main__':
     unittest.main()
-

sources/pyside6/tests/signals/signal_with_primitive_type_test.py

@@ -10,7 +10,7 @@
 from init_paths import init_test_paths
 init_test_paths(False)
 
-from PySide6.QtCore import QCoreApplication, QObject, QTimeLine, SIGNAL
+from PySide6.QtCore import QCoreApplication, QTimeLine
 
 
 class SignalPrimitiveTypeTest(unittest.TestCase):
@@ -36,5 +36,3 @@ def testTimeLine(self):
 
 if __name__ == '__main__':
     unittest.main()
-
-

sources/pyside6/tests/signals/slot_reference_count_test.py

@@ -12,7 +12,7 @@
 from init_paths import init_test_paths
 init_test_paths(False)
 
-from PySide6.QtCore import QObject, SIGNAL, SLOT
+from PySide6.QtCore import QObject, SIGNAL
 
 
 class Dummy(QObject):