Increased coverage of ConverterImpl.hpp

Author: bblanchon

extras/tests/JsonVariant/undefined.cpp

@@ -67,4 +67,30 @@ TEST_CASE("JsonVariant undefined") {
       REQUIRE(variant.is<JsonObject>() == false);
     }
   }
+
+  SECTION("set<T>()") {
+    SECTION("long") {
+      REQUIRE(variant.set(42L) == false);
+    }
+
+    SECTION("unsigned") {
+      REQUIRE(variant.set(42U) == false);
+    }
+
+    SECTION("const char*") {
+      REQUIRE(variant.set("42") == false);
+    }
+
+    SECTION("Serialized<const char*>") {
+      REQUIRE(variant.set(serialized("42")) == false);
+    }
+
+    SECTION("double") {
+      REQUIRE(variant.set(42.0) == false);
+    }
+
+    SECTION("bool") {
+      REQUIRE(variant.set(true) == false);
+    }
+  }
 }

src/ArduinoJson/Variant/ConverterImpl.hpp

@@ -121,7 +121,6 @@ struct Converter<T, typename enable_if<is_floating_point<T>::value>::type> {
 template <>
 struct Converter<const char*> {
   static bool toJson(VariantRef variant, const char* value) {
-    // TODO: don't pass pool
     return variantSetString(getData(variant), adaptString(value),
                             getPool(variant));
   }