Skip to content

Commit 1c749f7

Browse files
committed
fix unit test failed
Signed-off-by: xuwenping <[email protected]>
1 parent c8cd9aa commit 1c749f7

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

logback-access/src/main/java/ch/qos/logback/access/pattern/DateConverter.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
import java.time.ZoneId;
1717
import java.util.List;
18+
import java.util.Locale;
1819

1920
import ch.qos.logback.access.spi.IAccessEvent;
2021
import ch.qos.logback.core.CoreConstants;
@@ -44,13 +45,19 @@ public void start() {
4445
zoneId = ZoneId.of(zoneIdString);
4546
}
4647

48+
Locale locale = null;
49+
if (optionList != null && optionList.size() > 2) {
50+
String localeIdStr = optionList.get(2);
51+
locale = Locale.forLanguageTag(localeIdStr);
52+
}
53+
4754
try {
48-
cachingDateFormatter = new CachingDateFormatter(datePattern, zoneId);
55+
cachingDateFormatter = new CachingDateFormatter(datePattern, zoneId, locale);
4956
// maximumCacheValidity = CachedDateFormat.getMaximumCacheValidity(pattern);
5057
} catch (IllegalArgumentException e) {
5158
addWarn("Could not instantiate SimpleDateFormat with pattern " + datePattern, e);
5259
addWarn("Defaulting to " + CoreConstants.CLF_DATE_PATTERN);
53-
cachingDateFormatter = new CachingDateFormatter(CoreConstants.CLF_DATE_PATTERN, zoneId);
60+
cachingDateFormatter = new CachingDateFormatter(CoreConstants.CLF_DATE_PATTERN, zoneId, locale);
5461
}
5562

5663
}

logback-access/src/test/java/ch/qos/logback/access/pattern/ConverterTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public void testDateConverter() {
7676
@Test
7777
public void testDateConverter_AU_locale() {
7878
DateConverter converter = new DateConverter();
79-
List<String> optionsList = Lists.list(CoreConstants.CLF_DATE_PATTERN, "Australia/Sydney", "en-AU");
79+
List<String> optionsList = Lists.list(CoreConstants.CLF_DATE_PATTERN, "Australia/Sydney", "en_AU");
8080

8181
converter.setOptionList(optionsList);
8282
converter.start();

logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemoval_Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ public void dailySizeBasedRolloverWithSizeCap() {
291291
// 2016-03-05 00:14:39 CET
292292
long simulatedTime = 1457133279186L;
293293
ConfigParameters params = new ConfigParameters(simulatedTime);
294-
String fileNamePattern = randomOutputDir + "/%d{" + DAILY_DATE_PATTERN + "}-clean.%i";
294+
String fileNamePattern = randomOutputDir + "/%d{" + DAILY_DATE_PATTERN + ", CET}-clean.%i";
295295
params.maxHistory(60).fileNamePattern(fileNamePattern).simulatedNumberOfPeriods(10).sizeCap(sizeCap);
296296
logOverMultiplePeriods(params);
297297

0 commit comments

Comments
 (0)