Skip to content

Commit 93f5327

Browse files
authored
minor changes after deployment (#3426)
* minor changes after deployment * update qiime 2 * update conda qiime2 to 3.10 * install tiny Q2 * rm conda update * qtp-biom * tiny -> amplicon * fix workflow GUI * nltk<=3.8.1
1 parent c98cc7e commit 93f5327

File tree

5 files changed

+32
-22
lines changed

5 files changed

+32
-22
lines changed

.github/workflows/qiita-ci.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,7 @@ jobs:
104104
- name: Install plugins
105105
shell: bash -l {0}
106106
run: |
107-
wget https://data.qiime2.org/distro/core/qiime2-2022.11-py38-linux-conda.yml
108-
conda env create --quiet -n qtp-biom --file qiime2-2022.11-py38-linux-conda.yml
109-
rm qiime2-2022.11-py38-linux-conda.yml
107+
conda env create -n qtp-biom --file https://data.qiime2.org/distro/amplicon/qiime2-amplicon-2024.5-py39-linux-conda.yml
110108
export QIITA_ROOTCA_CERT=`pwd`/qiita_core/support_files/ci_rootca.crt
111109
export QIITA_CONFIG_FP=`pwd`/qiita_core/support_files/config_test.cfg
112110
export REDBIOM_HOST="http://localhost:7379"

qiita_db/artifact.py

Lines changed: 28 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1342,23 +1342,6 @@ def _helper(sql_edges, edges, nodes):
13421342
# If the job is in success we don't need to do anything
13431343
# else since it would've been added by the code above
13441344
if jstatus != 'success':
1345-
# Connect the job with his input artifacts, the
1346-
# input artifacts may or may not exist yet, so we
1347-
# need to check both the input_artifacts and the
1348-
# pending properties
1349-
for in_art in n_obj.input_artifacts:
1350-
iid = in_art.id
1351-
if iid not in nodes and iid in extra_nodes:
1352-
nodes[iid] = extra_nodes[iid]
1353-
_add_edge(edges, nodes[iid], nodes[n_obj.id])
1354-
1355-
pending = n_obj.pending
1356-
for pred_id in pending:
1357-
for pname in pending[pred_id]:
1358-
in_node_id = '%s:%s' % (
1359-
pred_id, pending[pred_id][pname])
1360-
_add_edge(edges, nodes[in_node_id],
1361-
nodes[n_obj.id])
13621345

13631346
if jstatus != 'error':
13641347
# If the job is not errored, we can add the
@@ -1380,6 +1363,34 @@ def _helper(sql_edges, edges, nodes):
13801363
queue.append(cjob.id)
13811364
if cjob.id not in nodes:
13821365
nodes[cjob.id] = ('job', cjob)
1366+
1367+
# including the outputs
1368+
for o_name, o_type in cjob.command.outputs:
1369+
node_id = '%s:%s' % (cjob.id, o_name)
1370+
node = TypeNode(
1371+
id=node_id, job_id=cjob.id,
1372+
name=o_name, type=o_type)
1373+
if node_id not in nodes:
1374+
nodes[node_id] = ('type', node)
1375+
1376+
# Connect the job with his input artifacts, the
1377+
# input artifacts may or may not exist yet, so we
1378+
# need to check both the input_artifacts and the
1379+
# pending properties
1380+
for in_art in n_obj.input_artifacts:
1381+
iid = in_art.id
1382+
if iid not in nodes and iid in extra_nodes:
1383+
nodes[iid] = extra_nodes[iid]
1384+
_add_edge(edges, nodes[iid], nodes[n_obj.id])
1385+
1386+
pending = n_obj.pending
1387+
for pred_id in pending:
1388+
for pname in pending[pred_id]:
1389+
in_node_id = '%s:%s' % (
1390+
pred_id, pending[pred_id][pname])
1391+
_add_edge(edges, nodes[in_node_id],
1392+
nodes[n_obj.id])
1393+
13831394
elif n_type == 'type':
13841395
# Connect this 'future artifact' with the job that will
13851396
# generate it

qiita_db/util.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2775,7 +2775,7 @@ def update_resource_allocation_table(weeks=1, test=None):
27752775
sacct = [
27762776
'sacct', '-p',
27772777
'--format=JobID,ElapsedRaw,MaxRSS,Submit,Start,End,CPUTimeRAW,'
2778-
'ReqMem,AllocCPUs,AveVMSize', '--starttime',
2778+
'ReqMem,AllocCPUs,AveVMSize,MaxVMSizeNode', '--starttime',
27792779
dates[0].strftime('%Y-%m-%d'), '--endtime',
27802780
dates[1].strftime('%Y-%m-%d'), '--user', 'qiita', '--state', 'CD']
27812781

@@ -2894,6 +2894,7 @@ def merge_rows(rows):
28942894
df['MaxRSSRaw'] = df.MaxRSS.apply(lambda x: MaxRSS_helper(str(x)))
28952895
df['ElapsedRawTime'] = df.ElapsedRaw.apply(
28962896
lambda x: timedelta(seconds=float(x)))
2897+
df.replace({np.nan: None}, inplace=True)
28972898

28982899
for index, row in df.iterrows():
28992900
with qdb.sql_connection.TRN:

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@
105105
install_requires=['psycopg2', 'click', 'bcrypt', 'pandas<2.0',
106106
'biom-format', 'tornado<6.0', 'toredis', 'redis',
107107
'scp', 'pyparsing', 'h5py', 'natsort', 'nose', 'pep8',
108-
'networkx', 'humanize', 'wtforms<3.0.0', 'nltk',
108+
'networkx', 'humanize', 'wtforms<3.0.0', 'nltk<=3.8.1',
109109
'openpyxl', 'sphinx-bootstrap-theme', 'Sphinx<3.0',
110110
'gitpython', 'redbiom', 'pyzmq', 'sphinx_rtd_theme',
111111
'paramiko', 'seaborn', 'matplotlib', 'scipy<=1.10.1',

0 commit comments

Comments
 (0)