Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop feature importance outputs for estimators that do not calculate importance scores #153

Open
nbokulich opened this issue Jul 15, 2019 · 0 comments

Comments

@nbokulich
Copy link
Member

Improvement Description
Now that we have TypeMap... A few estimators do not actually report feature importances, so let's no longer have them output fake feature importance scores. See this TODO:

# TODO: drop this when we get around to supporting optional outputs
# methods cannot output an empty importances artifact; only KNN has no
# feature importance, but just warn and output all features as
# importance = 1

Current Behavior
For knn (and any other estimators that do not calculate importance), importance = 1 for all features, and we issue a warning that these are fake.

Proposed Behavior
No longer output these scores.

@nbokulich nbokulich added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 15, 2019
@Oddant1 Oddant1 pinned this issue Jul 16, 2019
@Oddant1 Oddant1 unpinned this issue Jul 16, 2019
@nbokulich nbokulich removed good first issue Good for newcomers help wanted Extra attention is needed labels May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant