fix linters warnings

Author: Mikhail Podtserkovskiy

README.md

@@ -1,4 +1,4 @@
-# ~~jsonwire-grid~~WebDriverGrid [![Build Status](https://travis-ci.org/qa-dev/jsonwire-grid.svg?branch=master)](https://travis-ci.org/qa-dev/jsonwire-grid)
+# ~~jsonwire-grid~~WebDriverGrid [![Build Status](https://travis-ci.org/qa-dev/jsonwire-grid.svg?branch=master)](https://travis-ci.org/qa-dev/jsonwire-grid) [![Go Report Card](https://goreportcard.com/badge/github.com/qa-dev/jsonwire-grid)](https://goreportcard.com/report/github.com/qa-dev/jsonwire-grid)
 This is high-performance scalable implementation of Selenium Grid (hub),
 ###### What is Selenium-Grid?
 >Selenium-Grid allows you run your tests on different machines against different browsers in parallel. That is, running multiple tests at the same time against different machines running different browsers and operating systems. Essentially, Selenium-Grid support distributed test execution. It allows for running your tests in a distributed test execution environment.

config/config.go

@@ -7,13 +7,15 @@ import (
 	"os"
 )
 
+// Config - settings of application.
 type Config struct {
 	Logger Logger `json:"logger"`
 	DB     DB     `json:"db"`
 	Grid   Grid   `json:"grid"`
 	Statsd Statsd `json:"statsd"`
 }
 
+// Grid general settings
 type Grid struct {
 	ClientType       string     `json:"client_type"`
 	Port             int        `json:"port"`
@@ -23,27 +25,32 @@ type Grid struct {
 	ReservedDuration string `json:"reserved_node_duration"` // duration string format ex. 12m, see time.ParseDuration()
 }
 
+// Strategy - Describes the algorithm of node selection.
 type Strategy struct {
 	Params   json.RawMessage `json:"params"` // ex. docker config, kubernetes config, etc.
 	Type     string          `json:"type"`
 	Limit    int             `json:"limit"`
 	NodeList []Node          `json:"node_list"`
 }
 
+// Node - Describes node properties and capabilities. Applicable only for on-demand strategies.
 type Node struct {
 	Params           json.RawMessage          `json:"params"` // ex. image_name, etc.
 	CapabilitiesList []map[string]interface{} `json:"capabilities_list"`
 }
 
+// Logger - Configuration of logger.
 type Logger struct {
 	Level string `json:"level"`
 }
 
+// DB - Configuration of storage.
 type DB struct {
 	Implementation string `json:"implementation"`
 	Connection     string `json:"connection"`
 }
 
+// Statsd - Settings of metrics sender.
 type Statsd struct {
 	Host     string `json:"host"`
 	Port     int    `json:"port"`
@@ -52,10 +59,12 @@ type Statsd struct {
 	Enable   bool   `json:"enable"`
 }
 
+// New - Constructor of config.
 func New() *Config {
 	return &Config{}
 }
 
+// LoadFromFile - config loader from json file.
 func (c *Config) LoadFromFile(path string) error {
 	log.Printf(path)
 	if path == "" {

handlers/apiProxy.go

@@ -8,6 +8,7 @@ import (
 	"github.com/qa-dev/jsonwire-grid/pool"
 )
 
+// APIProxy - responds with information about whether the node is registered.
 type APIProxy struct {
 	Pool *pool.Pool
 }

handlers/createSession.go

@@ -16,6 +16,7 @@ import (
 	"net/url"
 )
 
+// CreateSession - Receives requests to create session.
 type CreateSession struct {
 	Pool          *pool.Pool
 	ClientFactory jsonwire.ClientFactoryInterface

handlers/registerNode.go

@@ -12,6 +12,7 @@ import (
 	"github.com/qa-dev/jsonwire-grid/pool/capabilities"
 )
 
+// RegisterNode - Receives requests to register nodes for persistent strategy.
 type RegisterNode struct {
 	Pool *pool.Pool
 }

handlers/useSession.go

@@ -10,6 +10,7 @@ import (
 	"github.com/qa-dev/jsonwire-grid/pool"
 )
 
+// UseSession - Receives requests to use session.
 type UseSession struct {
 	Pool  *pool.Pool
 	Cache *pool.Cache

jsonwire/interfaces.go

@@ -1,16 +1,14 @@
 package jsonwire
 
+// ClientFactoryInterface - is an abstract http-client factory for node implementations.
 type ClientFactoryInterface interface {
 	Create(address string) ClientInterface
 }
 
+// ClientInterface - is an abstract http-client for node implementations.
 type ClientInterface interface {
 	Health() (*Message, error)
 	Sessions() (*Sessions, error)
 	CloseSession(sessionID string) (*Message, error)
 	Address() string
 }
-
-type NodeInterface interface {
-	RemoveAllSessions() (int, error)
-}

jsonwire/jsonwire.go

@@ -4,19 +4,22 @@ import (
 	"encoding/json"
 )
 
+// Message - common protocol message structure.
 type Message struct {
 	SessionID string      `json:"sessionId"`
 	Status    int         `json:"status"`
 	Value     interface{} `json:"value"`
 }
 
+// NewSession - message structure for the creation of a new session
 type NewSession struct {
 	Message
 	Value struct {
 		SessionID string `json:"sessionId"`
 	} `json:"value"`
 }
 
+// Sessions - message structure for sessions list.
 type Sessions struct {
 	Message
 	Value []struct {
@@ -25,31 +28,35 @@ type Sessions struct {
 	} `json:"value"`
 }
 
+// Register - message structure for registration new node.
 type Register struct {
 	Class            string         `json:"class,omitempty"`
 	Configuration    *Configuration `json:"configuration,omitempty"`
 	CapabilitiesList []Capabilities `json:"capabilities,omitempty"` // selenium 3
 }
 
+// Capabilities - structure of supported capabilities.
 type Capabilities map[string]interface{}
 
+// Configuration - structure of node configuration.
 type Configuration struct {
-	Id               string         `json:"id,omitempty"`
-	Proxy            string         `json:"proxy,omitempty"`
-	Role             string         `json:"role,omitempty"`
-	Hub              string         `json:"hub,omitempty"`
-	Port             int            `json:"port,omitempty"`
-	RemoteHost       string         `json:"remoteHost,omitempty"`
-	Host             string         `json:"host,omitempty"`
-	MaxSession       int            `json:"maxSession,omitempty"`
-	HubHost          string         `json:"hubHost,omitempty"`
+	ID         string `json:"id,omitempty"`
+	Proxy      string `json:"proxy,omitempty"`
+	Role       string `json:"role,omitempty"`
+	Hub        string `json:"hub,omitempty"`
+	Port       int    `json:"port,omitempty"`
+	RemoteHost string `json:"remoteHost,omitempty"`
+	Host       string `json:"host,omitempty"`
+	MaxSession int    `json:"maxSession,omitempty"`
+	HubHost    string `json:"hubHost,omitempty"`
 	RegisterCycle    int            `json:"registerCycle,omitempty"`
 	HubPort          int            `json:"hubPort,omitempty"`
 	URL              string         `json:"url,omitempty"`
 	Register         bool           `json:"register,omitempty"`
 	CapabilitiesList []Capabilities `json:"capabilities,omitempty"` // selenium 2
 }
 
+// APIProxy - message structure for node check.
 type APIProxy struct {
 	ID      string      `json:"id"`
 	Request interface{} `json:"request"` //todo: пока не ясно зачем он нужен

jsonwire/mocks.go

@@ -4,34 +4,41 @@ import (
 	"github.com/stretchr/testify/mock"
 )
 
+// ClientFactoryMock - mock of factory of client.
 type ClientFactoryMock struct {
 	mock.Mock
 }
 
+// Create - mock of create session.
 func (cf *ClientFactoryMock) Create(address string) ClientInterface {
 	args := cf.Called(address)
 	return args.Get(0).(ClientInterface)
 }
 
+// ClientMock - mock of client.
 type ClientMock struct {
 	mock.Mock
 }
 
+// Health - mock of healthcheck.
 func (c *ClientMock) Health() (*Message, error) {
 	args := c.Called()
 	return args.Get(0).(*Message), args.Error(1)
 }
 
+// Sessions - mock of sessions list.
 func (c *ClientMock) Sessions() (*Sessions, error) {
 	args := c.Called()
 	return args.Get(0).(*Sessions), args.Error(1)
 }
 
+// CloseSession - mock of close session.
 func (c *ClientMock) CloseSession(sessionID string) (*Message, error) {
 	args := c.Called(sessionID)
 	return args.Get(0).(*Message), args.Error(1)
 }
 
+// Address - mock of get node address.
 func (c *ClientMock) Address() string {
 	args := c.Called()
 	return args.String(0)

logger/logger.go

@@ -7,6 +7,7 @@ import (
 	"github.com/qa-dev/jsonwire-grid/config"
 )
 
+// Init - initialisation of logger.
 func Init(logger config.Logger) error {
 	level, err := logrus.ParseLevel(logger.Level)
 	if err != nil {