Skip to content

Inline comments in tox.ini cause error #34

@webknjaz

Description

@webknjaz
  • Dependency Parser version: N/A
  • Python version: 3.7
  • Operating System: GNU/Linux

Description

Tox parses deps with comments as part of dep names. I know that it's not a parsed bug essentially but it would be nice to allow putting such comments on top of those deps lines instead of inline.

What I Did

So there's this in tox.ini:

deps =
    yapf>=0.25.0,<0.27  # pyup: < 0.27 # disable updates, conflicts with flake8 as per https://github.com/ansible/molecule/pull/1915

And tox tries to pip install "yapf>=0.25.0,<0.27 # pyup: < 0.27 # disable updates, conflicts with flake8 as per https://github.com/ansible/molecule/pull/1915" under the hood with fails with

ERROR: could not install deps [flake8>=3.6.0,<4, yamllint>=1.11.1,<2, mock==2.0.0, pytest==3.6.0, pytest-cov==2.6.0, pytest-helpers-namespace==2019.1.8, pytest-mock==1.10.0, pytest-verbose-parametrize==1.4.0, pytest-xdist==1.26.0, shade==1.22.2, yapf>=0.25.0,<0.27  # pyup: < 0.27 # disable updates, conflicts with flake8 as per https://github.com/ansible/molecule/pull/1915, ansible>=2.7,<2.8]; v = InvocationError("/home/travis/build/ansible/molecule/.tox/ansible27-unit/bin/python -m pip install 'flake8>=3.6.0,<4' 'yamllint>=1.11.1,<2' mock==2.0.0 pytest==3.6.0 pytest-cov==2.6.0 pytest-helpers-namespace==2019.1.8 pytest-mock==1.10.0 pytest-verbose-parametrize==1.4.0 pytest-xdist==1.26.0 shade==1.22.2 'yapf>=0.25.0,<0.27  # pyup: < 0.27 # disable updates, conflicts with flake8 as per https://github.com/ansible/molecule/pull/1915' 'ansible>=2.7,<2.8'", 1)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions