Skip to content

Back out "Resolve run_opts before passing it to the workspace (#755) (#755)" #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

miqueljubert
Copy link

Summary:
Original commit changeset: b3e964613444

Original Phabricator Diff: D48395915

Differential Revision: D48430887

…h#755) (pytorch#755)"

Summary:
Original commit changeset: b3e964613444

Original Phabricator Diff: D48395915

Differential Revision: D48430887

fbshipit-source-id: 3fdbe84652f8ad07083b16724eadbc2aa7e828f0
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 17, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48430887

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #760 (098316c) into main (3a253be) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
+ Coverage   92.78%   92.81%   +0.02%     
==========================================
  Files          96       96              
  Lines        6073     6080       +7     
==========================================
+ Hits         5635     5643       +8     
+ Misses        438      437       -1     
Flag Coverage Δ
unittests 92.81% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
torchx/runner/api.py 96.33% <100.00%> (ø)
torchx/schedulers/api.py 94.33% <100.00%> (-0.06%) ⬇️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kiukchung
Copy link
Contributor

kiukchung commented Aug 17, 2023

@kurman (since you approved #755) and @manav-a can you take a look at this? seems like PR-755 was BC breaking?

@miqueljubert
Copy link
Author

We fixed this forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants