-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata to dist/spdm components #1037
Comments
If everyone is in favor I'm happy to contribute as always @d4l3k @kiukchung @tonykao8080 |
@clumsy sounds reasonable to me! I wonder if this is generic enough that we should support it for all components via run/.torchxconfig |
I think many schedulers have some notion of metadata/tags - so that we can mark the job itself for some automation, but not leak this into the app. We have added this to AWS Batch already, I can add to AWS SageMaker and maybe Kubernetes if it's missing there. |
The implementation is trivial (see the linked PR) @d4l3k We used it in a custom component, but don't want to maintain it internally long term just for this. |
I forgot that app.metadata support was added to AWS SageMaker scheduler since day 1. |
I can add |
Description
TorchX already supports App
metadata
. Unfortunately there's no way to passmetadata
via torchxconfig or CLI unlikeenv
.Motivation/Background
While implementation is scheduler specific and not all of them handle metadata. In AWS Batch we already translate
metadata
to Batch job tags: #775. It is also added to AWS SageMaker scheduler.If we add
metadata
todist
/spmd
the TorchX users will have 1 less reason to create custom components only to copydist
/spmd
almost verbatim.Detailed Proposal
Add a new parameter to
dist
/spmd
component, just likeenv
.Alternatives
The users are forced to implement their own components and deviate from vanilla TorchX.
Additional context/links
#775
The text was updated successfully, but these errors were encountered: