Skip to content

Commit cb2407f

Browse files
authored
Fix broken doc-push (#1034) (#1034)
Summary: Pull Request resolved: #1034 I fixed doc-build in #1033 by: 1. pinning `protobuf-3.20.x` in torchx's `dev-requirements.txt` since `apache-airflow` (defined in `docs/requirements.txt`) was upgrading to `protobuf>=5.x` which is incompatible with `kfp-1.8.x`. 2. installing `doc/requirements.txt` FIRST, then installing `torchx` so that the pinned version of `protobuf` is honored. The above fixes `doc-build` but not `doc-push` because `doc-push` runs `scripts/doc-push.sh` which needed the same change as #2. NOTE: this wasn't caught in #1033 because we don't run `doc-push` for PRs (doc-push only runs for releases and commits in trunk since it literally pushes the built docs to https://pytorch.org/torchx) Differential Revision: D72059926
1 parent 87e3e08 commit cb2407f

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

Diff for: docs/doc_push.sh

+6-2
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,12 @@ else
5454
redirects=(latest main)
5555
fi
5656

57-
echo "Installing torchx from $repo_root..."
57+
echo "Installing TorchX and Doc dependencies from $repo_root..."
5858
cd "$repo_root" || exit
59+
60+
# First install doc requirements, then install torchx
61+
# so that torchx's pinned requirements are honored
62+
pip install -r docs/requirements.txt
5963
pip uninstall -y torchx
6064
pip install -r dev-requirements.txt
6165
python setup.py install
@@ -66,7 +70,7 @@ echo "Building torchx-$torchx_ver docs..."
6670
docs_dir=$repo_root/docs
6771
build_dir=$docs_dir/build
6872
cd "$docs_dir" || exit
69-
pip install -r requirements.txt
73+
7074
make clean html
7175
echo "Doc build complete"
7276

0 commit comments

Comments
 (0)