Skip to content

Commit 4174c94

Browse files
aivanoufacebook-github-bot
authored andcommitted
(torchx/specs) temporarily add back base_image to Role to keep backward compatibility with older fbpkgs in workflows (#229)
Summary: Pull Request resolved: #229 makes torchx_run_gang workflow backward compatible with workflows that still have base_image Solves: https://fb.workplace.com/groups/140700188041197/permalink/203080498469832/ Reviewed By: kiukchung Differential Revision: D31513305 fbshipit-source-id: b72f47b072fa1971983fd5d1c2115242aadee9d7
1 parent 9a4fd74 commit 4174c94

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

torchx/specs/api.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,7 @@ class Role:
221221

222222
name: str
223223
image: str
224+
base_image: Optional[str] = None # DEPRECATED DO NOT SET, WILL BE REMOVED SOON
224225
entrypoint: str = MISSING
225226
args: List[str] = field(default_factory=list)
226227
env: Dict[str, str] = field(default_factory=dict)

0 commit comments

Comments
 (0)