fix broken tests (#7)

Summary:
Pull Request resolved: #7

`get_file_contents` method in `cmd_run` was not properly implemented (was trying to read from `$root/torchx/cli/torchx/cli/conf` intead of `$root/torchx/cli/conf`)

Reviewed By: drdarshan

Differential Revision: D28620895

fbshipit-source-id: 8eabd9feb8915dbba6077f783ecb5ecc6ffd109b

Author: Kiuk Chung

torchx/cli/cmd_run.py

@@ -107,8 +107,11 @@ def get_file_contents(conf_file: str) -> Optional[str]:
     Example: ``get_file("torchx/cli/config/foo.txt")``
     """
 
-    root = path.dirname(__file__).replace(__name__.replace(".", path.sep), "")
+    module = __name__.replace(".", path.sep)  # torchx/cli/cmd_run
+    module_path, _ = path.splitext(__file__)  # $root/torchx/cli/cmd_run
+    root = module_path.replace(module, "")
     abspath = path.join(root, conf_file)
+
     if path.exists(abspath):
         with open(abspath, "r") as f:
             return f.read()

torchx/cli/test/cmd_run_test.py

@@ -15,7 +15,7 @@
 from typing import Generator
 from unittest.mock import MagicMock, patch
 
-from torchx.cli.cmd_run import CmdBuiltins, CmdRun, _builtins
+from torchx.cli.cmd_run import CmdBuiltins, CmdRun, _builtins, get_file_contents
 
 
 @contextmanager
@@ -120,6 +120,10 @@ def test_run_dryrun(self, mock_runner_run: MagicMock) -> None:
         self.cmd_run.run(args)
         mock_runner_run.assert_not_called()
 
+    def test_get_file_contents(self) -> None:
+        content = get_file_contents("torchx/cli/config/echo.torchx")
+        self.assertIsNotNone(content)
+
 
 class CmdBuiltinTest(unittest.TestCase):
     def test_run(self) -> None: