Skip to content

Commit 75ac42e

Browse files
authored
[CI] Remove sarif upload in lint (#6905)
remove sarif upload I think this causes comments like ![image](https://github.com/user-attachments/assets/e543ef32-8542-4e54-aaaa-323c1703fd9f) I don't like it because I'd rather just look at the lint job, depending on the linter it puts comments on unrelated lines, and when it does comment on the right line it doesnt suggest changes so you still have to run lintrunner yourself
1 parent a81292c commit 75ac42e

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

.github/workflows/lint.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,3 @@ jobs:
4646
if: always() && matrix.os == 'ubuntu-latest'
4747
run: |
4848
python tools/linter/convert_to_sarif.py --input lint.json --output lintrunner.sarif
49-
- name: Upload SARIF file
50-
if: always() && matrix.os == 'ubuntu-latest'
51-
continue-on-error: true
52-
uses: github/codeql-action/upload-sarif@28deaeda66b76a05916b6923827895f2b14ab387 # v3.28.16
53-
with:
54-
# Path to SARIF file relative to the root of the repository
55-
sarif_file: lintrunner.sarif
56-
category: lintrunner
57-
checkout_path: ${{ github.workspace }}

0 commit comments

Comments
 (0)