Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenizer test (#21) #8586

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Feb 19, 2025

Summary: Pull Request resolved: pytorch-labs/tokenizers#21

Test Plan:

OSS

Build

cmake .     -DCMAKE_INSTALL_PREFIX=cmake-out -DTOKENIZERS_BUILD_TEST=ON -Bcmake-out
cmake --build cmake-out -j9 --target install

Test

(executorch) [[email protected] /data/users/lfq/tokenizers/cmake-out (lfq.tokenizer-test)]$ ctest
Test project /data/users/lfq/tokenizers/cmake-out
    Start 1: test_base64
1/5 Test https://github.com/pytorch-labs/tokenizers/issues/1: test_base64 ......................   Passed    0.00 sec
    Start 2: test_llama2c_tokenizer
2/5 Test https://github.com/pytorch-labs/tokenizers/issues/2: test_llama2c_tokenizer ...........   Passed    0.00 sec
    Start 3: test_pre_tokenizer
3/5 Test https://github.com/pytorch-labs/tokenizers/issues/3: test_pre_tokenizer ...............   Passed    0.73 sec
    Start 4: test_sentencepiece
4/5 Test https://github.com/pytorch-labs/tokenizers/issues/4: test_sentencepiece ...............   Passed    0.04 sec
    Start 5: test_tiktoken
5/5 Test https://github.com/pytorch-labs/tokenizers/issues/5: test_tiktoken ....................   Passed    3.32 sec

100% tests passed, 0 tests failed out of 5

Total Test time (real) =   4.10 sec

Internal

 buck2 test fbsource//xplat/pytorch/tokenizers/test:
 buck2 test fbcode//pytorch/tokenizers/test:

Differential Revision: D69860352

Pulled By: lucylq

Copy link

pytorch-bot bot commented Feb 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8586

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 4e19077 with merge base 69ac165 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 19, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69860352

@lucylq lucylq requested a review from larryliu0820 February 19, 2025 22:14
lucylq added a commit to lucylq/tokenizers that referenced this pull request Feb 19, 2025
Summary:
X-link: pytorch/executorch#8586


Test Plan:
## OSS 
Build
```
cmake .     -DCMAKE_INSTALL_PREFIX=cmake-out -DTOKENIZERS_BUILD_TEST=ON -Bcmake-out
cmake --build cmake-out -j9 --target install
```

Test
```
(executorch) [[email protected] /data/users/lfq/tokenizers/cmake-out (lfq.tokenizer-test)]$ ctest
Test project /data/users/lfq/tokenizers/cmake-out
    Start 1: test_base64
1/5 Test pytorch-labs#1: test_base64 ......................   Passed    0.00 sec
    Start 2: test_llama2c_tokenizer
2/5 Test pytorch-labs#2: test_llama2c_tokenizer ...........   Passed    0.00 sec
    Start 3: test_pre_tokenizer
3/5 Test pytorch-labs#3: test_pre_tokenizer ...............   Passed    0.73 sec
    Start 4: test_sentencepiece
4/5 Test pytorch-labs#4: test_sentencepiece ...............   Passed    0.04 sec
    Start 5: test_tiktoken
5/5 Test pytorch-labs#5: test_tiktoken ....................   Passed    3.32 sec

100% tests passed, 0 tests failed out of 5

Total Test time (real) =   4.10 sec
```

## Internal
```
 buck2 test fbsource//xplat/pytorch/tokenizers/test:
 buck2 test fbcode//pytorch/tokenizers/test:
```

Reviewed By: larryliu0820

Differential Revision: D69860352

Pulled By: lucylq
Summary:

X-link: pytorch-labs/tokenizers#21

Test Plan:
## OSS 
Build
```
cmake .     -DCMAKE_INSTALL_PREFIX=cmake-out -DTOKENIZERS_BUILD_TEST=ON -Bcmake-out
cmake --build cmake-out -j9 --target install
```

Test
```
(executorch) [[email protected] /data/users/lfq/tokenizers/cmake-out (lfq.tokenizer-test)]$ ctest
Test project /data/users/lfq/tokenizers/cmake-out
    Start 1: test_base64
1/5 Test pytorch-labs/tokenizers#1: test_base64 ......................   Passed    0.00 sec
    Start 2: test_llama2c_tokenizer
2/5 Test pytorch-labs/tokenizers#2: test_llama2c_tokenizer ...........   Passed    0.00 sec
    Start 3: test_pre_tokenizer
3/5 Test pytorch-labs/tokenizers#3: test_pre_tokenizer ...............   Passed    0.73 sec
    Start 4: test_sentencepiece
4/5 Test pytorch-labs/tokenizers#4: test_sentencepiece ...............   Passed    0.04 sec
    Start 5: test_tiktoken
5/5 Test pytorch-labs/tokenizers#5: test_tiktoken ....................   Passed    3.32 sec

100% tests passed, 0 tests failed out of 5

Total Test time (real) =   4.10 sec
```

## Internal
```
 buck2 test fbsource//xplat/pytorch/tokenizers/test:
 buck2 test fbcode//pytorch/tokenizers/test:
```

Reviewed By: larryliu0820

Differential Revision: D69860352

Pulled By: lucylq
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69860352

@facebook-github-bot facebook-github-bot merged commit 9de9ed4 into pytorch:main Feb 20, 2025
47 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants