run mtk_build_examples.sh error

[MrJungle1]

🐛 Describe the bug

error：
[ 80%] Built target log_internal_message
[ 81%] Building CXX object tokenizers/third-party/abseil/absl/log/CMakeFiles/log_internal_check_op.dir/internal/check_op.cc.o
[ 82%] Building CXX object executor_runner/llama_runner/CMakeFiles/mtk_llama_executor_lib.dir/MultiModelLoader.cpp.o
[ 83%] Building CXX object tokenizers/third-party/abseil/absl/log/CMakeFiles/die_if_null.dir/die_if_null.cc.o
[ 83%] Linking CXX static library libabsl_status.a
[ 83%] Linking CXX static library libabsl_raw_hash_set.a
[ 83%] Built target status
[ 83%] Building CXX object executor_runner/llama_runner/CMakeFiles/mtk_llama_executor_lib.dir/ModelChunk.cpp.o
[ 83%] Built target raw_hash_set
[ 83%] Building CXX object tokenizers/third-party/abseil/absl/status/CMakeFiles/statusor.dir/statusor.cc.o
[ 83%] Linking CXX static library libabsl_die_if_null.a
[ 83%] Built target die_if_null
[ 83%] Building CXX object executor_runner/llama_runner/CMakeFiles/mtk_llama_executor_lib.dir/LlamaModelChunk.cpp.o
In file included from /workspace/executorch/examples/mediatek/executor_runner/llama_runner/ModelChunk.cpp:9:
In file included from /workspace/executorch/examples/mediatek/executor_runner/llama_runner/ModelChunk.h:15:
In file included from /workspace/executorch/examples/mediatek/../../../executorch/runtime/executor/method.h:17:
In file included from /workspace/executorch/examples/mediatek/../../../executorch/runtime/core/evalue.h:10:
In file included from /workspace/executorch/examples/mediatek/../../../executorch/runtime/core/exec_aten/exec_aten.h:34:
In file included from /workspace/executorch/examples/mediatek/../../../executorch/runtime/core/array_ref.h:32:
In file included from /workspace/executorch/cmake-mtk-out/lib/cmake/ExecuTorch/../../../include/executorch/runtime/core/portable_type/c10/c10/util/irange.h:5:
In file included from /workspace/executorch/cmake-mtk-out/lib/cmake/ExecuTorch/../../../include/executorch/runtime/core/portable_type/c10/c10/util/TypeSafeSignMath.h:3:
/workspace/executorch/cmake-mtk-out/lib/cmake/ExecuTorch/../../../include/executorch/runtime/core/portable_type/c10/c10/macros/Macros.h:22:10: fatal error: 'c10/macros/cmake_macros.h' file not found
#include <c10/macros/cmake_macros.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 83%] Linking CXX static library libabsl_log_internal_check_op.a
[ 83%] Built target log_internal_check_op
[ 83%] Building CXX object tokenizers/third-party/abseil/absl/flags/CMakeFiles/flags_reflection.dir/reflection.cc.o
1 error generated.
gmake[2]: *** [executor_runner/llama_runner/CMakeFiles/mtk_llama_executor_lib.dir/build.make:93: executor_runner/llama_runner/CMakeFiles/mtk_llama_executor_lib.dir/ModelChunk.cpp.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
In file included from /workspace/executorch/examples/mediatek/executor_runner/llama_runner/LlamaModelChunk.cpp:15:
In file included from /workspace/executorch/examples/mediatek/../../../executorch/extension/evalue_util/print_evalue.h:13:
In file included from /workspace/executorch/examples/mediatek/../../../executorch/runtime/core/evalue.h:10:
In file included from /workspace/executorch/examples/mediatek/../../../executorch/runtime/core/exec_aten/exec_aten.h:34:
In file included from /workspace/executorch/examples/mediatek/../../../executorch/runtime/core/array_ref.h:32:
In file included from /workspace/executorch/cmake-mtk-out/lib/cmake/ExecuTorch/../../../include/executorch/runtime/core/portable_type/c10/c10/util/irange.h:5:
In file included from /workspace/executorch/cmake-mtk-out/lib/cmake/ExecuTorch/../../../include/executorch/runtime/core/portable_type/c10/c10/util/TypeSafeSignMath.h:3:
/workspace/executorch/cmake-mtk-out/lib/cmake/ExecuTorch/../../../include/executorch/runtime/core/portable_type/c10/c10/macros/Macros.h:22:10: fatal error: 'c10/macros/cmake_macros.h' file not found
#include <c10/macros/cmake_macros.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 83%] Linking CXX static library libabsl_statusor.a
[ 83%] Built target statusor
1 error generated.
gmake[2]: *** [executor_runner/llama_runner/CMakeFiles/mtk_llama_executor_lib.dir/build.make:107: executor_runner/llama_runner/CMakeFiles/mtk_llama_executor_lib.dir/LlamaModelChunk.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:6364: executor_runner/llama_runner/CMakeFiles/mtk_llama_executor_lib.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....
[ 84%] Linking CXX static library libabsl_flags_reflection.a
[ 84%] Built target flags_reflection
gmake: *** [Makefile:136: all] Error 2

Versions

commit 85cf6ce

cc @cccclai @neuropilot-captain @cbilgin

[cccclai]

Are you able to install executorch itself first?

[MrJungle1]

@cccclai I have already installed
(executorch) root@VM-252-19-tencentos:/workspace/executorch# pip show executorch
Name: executorch
Version: 0.7.0a0+85cf6ce
Summary: On-device AI across mobile, embedded and edge for PyTorch
Home-page: https://pytorch.org/executorch/
Author:
Author-email: PyTorch Team packages@pytorch.org
License: BSD License

    For "ExecuTorch" software
    
    Copyright (c) Meta Platforms, Inc. and affiliates.
    Copyright 2023 Arm Limited and/or its affiliates.
    Copyright (c) Qualcomm Innovation Center, Inc.
    Copyright (c) 2023 Apple Inc.
    Copyright (c) 2024 MediaTek Inc.
    Copyright 2023 NXP
    
    Redistribution and use in source and binary forms, with or without modification,
    are permitted provided that the following conditions are met:
    
     * Redistributions of source code must retain the above copyright notice, this
       list of conditions and the following disclaimer.
    
     * Redistributions in binary form must reproduce the above copyright notice,
       this list of conditions and the following disclaimer in the documentation
       and/or other materials provided with the distribution.
    
     * Neither the name Meta nor the names of its contributors may be used to
       endorse or promote products derived from this software without specific
       prior written permission.
    
    THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
    ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
    WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
    DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR
    ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
    (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
    LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
    ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
    (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
    SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Location: /root/anaconda3/envs/executorch/lib/python3.10/site-packages
Editable project location: /workspace/executorch
Requires: coremltools, expecttest, flatbuffers, hypothesis, mpmath, numpy, packaging, pandas, parameterized, pytest, pytest-rerunfailures, pytest-xdist, pyyaml, ruamel.yaml, sympy, tabulate, typing-extensions
Required-by:

[MrJungle1]

Building from Source use ./install_executorch.sh --editable

[cccclai]

I see, thanks for sharing. How did you build the mtk runner?

[cccclai]

The error messages show that the error happens when building executorch, hence I'm asking. @swolchok any chance it rings a bell? The error message seems related to the shared files.

[swolchok]

The error messages show that the error happens when building executorch, hence I'm asking. @swolchok any chance it rings a bell? The error message seems related to the shared files.

This happens if C10_USING_CUSTOM_GENERATED_MACROS is not defined. Anything in the repo that is 1) built as a separate CMake project and 2) sets up ExecuTorch include paths directly rather than picking them up from the executorch_core target's public target_compile_definitions needs to also define this macro. Code search shows we have to do this in several places; since this seems to be MTK-specific, we probably need to do it somewhere in the MTK runner as well. (Does this failing but CI being green imply that we're not testing this in CI?)

[MrJungle1]

just run mtk_build_examples.sh to build the mtk runner, mtk_oss_executor_runner and mtk_executor_runner have been generated in the cmake-android-out/examples/mediatek directory, but mtk_llama_executor_runner has not been generated

[cccclai]

The current ci covers till here https://github.com/pytorch/executorch/blob/main/.ci/scripts/build-mediatek-sdk.sh#L19C23-L19C30

we can add mtk_build_examples.sh as part of CI

[MrJungle1]

There is no problem with mtk_build.sh. The problem lies in generating mtk_llama_executor_runner.