Skip to content

Commit acd4b25

Browse files
pzhan9facebook-github-bot
authored andcommitted
Bump CODEC_MAX_FRAME_LENGTH to 1GB (#353)
Summary: Pull Request resolved: #353 As title. Reviewed By: colin2328, LucasLLC Differential Revision: D77389566 fbshipit-source-id: ebbd52aca4c5f7ab0c39d48abfb90877e51eb55b
1 parent 503d8b9 commit acd4b25

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

hyperactor/src/config.rs

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ use crate::attrs::declare_attrs;
2727
// Declare configuration keys using the new attrs system with defaults
2828
declare_attrs! {
2929
/// Maximum frame length for codec
30-
pub attr CODEC_MAX_FRAME_LENGTH: usize = 8 * 1024 * 1024; // 8 MB
30+
pub attr CODEC_MAX_FRAME_LENGTH: usize = 1024 * 1024 * 1024; // 1GB
3131

3232
/// Message delivery timeout
3333
pub attr MESSAGE_DELIVERY_TIMEOUT: Duration = Duration::from_secs(30);
@@ -286,7 +286,7 @@ mod tests {
286286
#[test]
287287
fn test_default_config() {
288288
let config = Attrs::new();
289-
assert_eq!(config[CODEC_MAX_FRAME_LENGTH], 8 * 1024 * 1024);
289+
assert_eq!(config[CODEC_MAX_FRAME_LENGTH], 1024 * 1024 * 1024);
290290
assert_eq!(config[MESSAGE_DELIVERY_TIMEOUT], Duration::from_secs(30));
291291
assert_eq!(
292292
config[MESSAGE_ACK_TIME_INTERVAL],
@@ -341,12 +341,12 @@ mod tests {
341341
// Reset global config to defaults to avoid interference from other tests
342342
global::reset_to_defaults();
343343

344-
assert_eq!(global::get(CODEC_MAX_FRAME_LENGTH), 8 * 1024 * 1024);
344+
assert_eq!(global::get(CODEC_MAX_FRAME_LENGTH), 1024 * 1024 * 1024);
345345
{
346346
let _guard = config.override_key(CODEC_MAX_FRAME_LENGTH, 1024);
347347
assert_eq!(global::get(CODEC_MAX_FRAME_LENGTH), 1024);
348348
}
349-
assert_eq!(global::get(CODEC_MAX_FRAME_LENGTH), 8 * 1024 * 1024);
349+
assert_eq!(global::get(CODEC_MAX_FRAME_LENGTH), 1024 * 1024 * 1024);
350350

351351
{
352352
let _guard = config.override_key(CODEC_MAX_FRAME_LENGTH, 1024);
@@ -355,7 +355,7 @@ mod tests {
355355
// The configuration will be automatically restored when _guard goes out of scope
356356
}
357357

358-
assert_eq!(global::get(CODEC_MAX_FRAME_LENGTH), 8 * 1024 * 1024);
358+
assert_eq!(global::get(CODEC_MAX_FRAME_LENGTH), 1024 * 1024 * 1024);
359359
}
360360

361361
#[test]
@@ -367,7 +367,7 @@ mod tests {
367367
assert!(config.is_empty());
368368

369369
// But getters should still return the defaults from the keys
370-
assert_eq!(config[CODEC_MAX_FRAME_LENGTH], 8 * 1024 * 1024);
370+
assert_eq!(config[CODEC_MAX_FRAME_LENGTH], 1024 * 1024 * 1024);
371371
assert_eq!(config[MESSAGE_DELIVERY_TIMEOUT], Duration::from_secs(30));
372372
assert_eq!(
373373
config[MESSAGE_ACK_TIME_INTERVAL],
@@ -386,7 +386,10 @@ mod tests {
386386
assert!(IS_MANAGED_SUBPROCESS.has_default());
387387

388388
// Verify we can get defaults directly from keys
389-
assert_eq!(CODEC_MAX_FRAME_LENGTH.default(), Some(&(8 * 1024 * 1024)));
389+
assert_eq!(
390+
CODEC_MAX_FRAME_LENGTH.default(),
391+
Some(&(1024 * 1024 * 1024))
392+
);
390393
assert_eq!(
391394
MESSAGE_DELIVERY_TIMEOUT.default(),
392395
Some(&Duration::from_secs(30))
@@ -435,7 +438,7 @@ mod tests {
435438
global::reset_to_defaults();
436439

437440
// Test the new lock/override API for individual config values
438-
assert_eq!(global::get(CODEC_MAX_FRAME_LENGTH), 8 * 1024 * 1024);
441+
assert_eq!(global::get(CODEC_MAX_FRAME_LENGTH), 1024 * 1024 * 1024);
439442
assert_eq!(
440443
global::get(MESSAGE_DELIVERY_TIMEOUT),
441444
Duration::from_secs(30)
@@ -452,7 +455,7 @@ mod tests {
452455
}
453456

454457
// Values should be restored after guard is dropped
455-
assert_eq!(global::get(CODEC_MAX_FRAME_LENGTH), 8 * 1024 * 1024);
458+
assert_eq!(global::get(CODEC_MAX_FRAME_LENGTH), 1024 * 1024 * 1024);
456459

457460
// Test multiple overrides
458461
{
@@ -467,7 +470,7 @@ mod tests {
467470
}
468471

469472
// All values should be restored
470-
assert_eq!(global::get(CODEC_MAX_FRAME_LENGTH), 8 * 1024 * 1024);
473+
assert_eq!(global::get(CODEC_MAX_FRAME_LENGTH), 1024 * 1024 * 1024);
471474
assert_eq!(
472475
global::get(MESSAGE_DELIVERY_TIMEOUT),
473476
Duration::from_secs(30)

0 commit comments

Comments
 (0)