Ensure name field of objects is not overriden by templates (#79)

Author: Cleptomania

pytiled_parser/parsers/json/tiled_object.py

@@ -337,6 +337,9 @@ def parse(
 
                             if not found:
                                 raw_object["properties"].append(prop)
+                    elif key == "name":
+                        if "name" not in raw_object:
+                            raw_object["name"] = loaded_template[key]
                     else:
                         raw_object[key] = loaded_template[key]  # type: ignore
         else:

tests/test_data/map_tests/template/expected.py

@@ -15,7 +15,7 @@
             tiled_objects=[
                 tiled_object.Rectangle(
                     id=2,
-                    name="",
+                    name="hello",
                     rotation=0,
                     size=common_types.Size(63.6585878103079, 38.2811778048473),
                     coordinates=common_types.OrderedPair(

tests/test_data/map_tests/template/map.json

@@ -17,6 +17,7 @@
                          "value":"hello"
                         }],
                  "template":"template-rectangle.json",
+                 "name": "hello",
                  "x":98.4987608686521,
                  "y":46.2385012811358
                 }, 

tests/test_data/map_tests/template/map.tmx

@@ -11,7 +11,7 @@
  <tileset firstgid="1" source="tileset.tsx"/>
  <tileset firstgid="49" source="tile_set_image_for_template.tsx"/>
  <objectgroup id="2" name="Object Layer 1">
-  <object id="2" template="template-rectangle.tx" x="98.4988" y="46.2385">
+  <object id="2" template="template-rectangle.tx" name="hello" x="98.4988" y="46.2385">
    <properties>
     <property name="test" value="hello"/>
    </properties>

tests/test_data/map_tests/template/template-rectangle.tx

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <template>
- <object width="63.6586" height="38.2812">
+ <object name="test" width="63.6586" height="38.2812">
     <properties>
         <property name="test" value="world"/>
         <property name="testtest" value="fromtemplate"/>