Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

email.policy.default doesn't work with email.parser.BytesParser or email.parser.Parser #13531

Open
dseomn opened this issue Feb 23, 2025 · 0 comments · May be fixed by #13532
Open

email.policy.default doesn't work with email.parser.BytesParser or email.parser.Parser #13531

dseomn opened this issue Feb 23, 2025 · 0 comments · May be fixed by #13532
Labels
stubs: false positive Type checkers report false errors

Comments

@dseomn
Copy link

dseomn commented Feb 23, 2025 •
edited
Loading

I just started getting a mypy error that I think is caused by the same issue, but it doesn't look like this PR touches email.parser.BytesParser at all. Would it make sense to change that in this PR too? Or should I file a separate bug?

Error:

rock_paper_sand/report_test.py:465: error: Argument "policy" to "BytesParser" has incompatible type "EmailPolicy[EmailMessage]"; expected "Policy[Message[str, str]]"  [arg-type]

Code:

        message = typing.cast(
            email.message.EmailMessage,
            email.parser.BytesParser(policy=email.policy.default).parsebytes(
                mock_subprocess_run.mock_calls[0].kwargs["input"]
            ),
        )

Originally posted by @dseomn in #13274 (comment)

mypy 1.15.0 also complains about parser.Parser(policy=policy.default) so i continue to use 1.13.0 and changed my code to use message_from_string in anticipation of this PR's deployment. happy to see more commits, but merging this PR as-is would be a step in the right direction.

Le mieux est l'ennemi du bien.

Originally posted by @cossor in #13274 (comment)
@dseomn dseomn changed the title email.policy.default doesn't work with email.parser.BytesParser email.policy.default doesn't work with email.parser.BytesParser or email.parser.Parser Feb 23, 2025
@srittau srittau added the stubs: false positive Type checkers report false errors label Feb 24, 2025
srittau added a commit to srittau/typeshed that referenced this issue Feb 24, 2025
@srittau
Clean up email message types
7f3862e 
* Unify the `_MessageT` type var in `email._policybase`.
* Use explicit type arguments for `Message` type in `_MessageT` type var.
  In particular, change bound from `Message[str, str]` to `Message[Any, Any]`.
* Change `__init__()` overloads of `Parser` and `BytesParser` to accept
  `Message` objects that are not `Message[str, str]` if `_class` is not also given.

Closes: python#13531
@srittau srittau linked a pull request Feb 24, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stubs: false positive Type checkers report false errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up and fix email message types srittau/typeshed
2 participants
@srittau @dseomn