Skip to content

Commit bf2d517

Browse files
jszopiJelleZijlstra
authored andcommitted
unittest: Add overloads to assert(Not)AlmostEqual(s) (#2901)
1 parent 12fa5c4 commit bf2d517

File tree

2 files changed

+39
-19
lines changed

2 files changed

+39
-19
lines changed

stdlib/2/unittest.pyi

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -89,20 +89,32 @@ class TestCase(Testable):
8989
msg: object = ...) -> None: ...
9090
def failIfEqual(self, first: Any, second: Any,
9191
msg: object = ...) -> None: ...
92-
def assertAlmostEqual(self, first: float, second: float, places: int = ...,
93-
msg: object = ...,
94-
delta: float = ...) -> None: ...
95-
def assertAlmostEquals(self, first: float, second: float, places: int = ...,
96-
msg: object = ...,
97-
delta: float = ...) -> None: ...
92+
@overload
93+
def assertAlmostEqual(self, first: float, second: float,
94+
places: int = ..., msg: Any = ...) -> None: ...
95+
@overload
96+
def assertAlmostEqual(self, first: float, second: float, *,
97+
msg: Any = ..., delta: float = ...) -> None: ...
98+
@overload
99+
def assertAlmostEquals(self, first: float, second: float,
100+
places: int = ..., msg: Any = ...) -> None: ...
101+
@overload
102+
def assertAlmostEquals(self, first: float, second: float, *,
103+
msg: Any = ..., delta: float = ...) -> None: ...
98104
def failUnlessAlmostEqual(self, first: float, second: float, places: int = ...,
99105
msg: object = ...) -> None: ...
100-
def assertNotAlmostEqual(self, first: float, second: float, places: int = ...,
101-
msg: object = ...,
102-
delta: float = ...) -> None: ...
103-
def assertNotAlmostEquals(self, first: float, second: float, places: int = ...,
104-
msg: object = ...,
105-
delta: float = ...) -> None: ...
106+
@overload
107+
def assertNotAlmostEqual(self, first: float, second: float,
108+
places: int = ..., msg: Any = ...) -> None: ...
109+
@overload
110+
def assertNotAlmostEqual(self, first: float, second: float, *,
111+
msg: Any = ..., delta: float = ...) -> None: ...
112+
@overload
113+
def assertNotAlmostEquals(self, first: float, second: float,
114+
places: int = ..., msg: Any = ...) -> None: ...
115+
@overload
116+
def assertNotAlmostEquals(self, first: float, second: float, *,
117+
msg: Any = ..., delta: float = ...) -> None: ...
106118
def failIfAlmostEqual(self, first: float, second: float, places: int = ...,
107119
msg: object = ...,
108120
delta: float = ...) -> None: ...

stdlib/3/unittest/__init__.pyi

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -110,11 +110,12 @@ class TestCase:
110110
self, logger: Optional[logging.Logger] = ...,
111111
level: Union[int, str, None] = ...
112112
) -> _AssertLogsContext: ...
113-
def assertAlmostEqual(self, first: float, second: float, places: int = ...,
114-
msg: Any = ..., delta: float = ...) -> None: ...
115113
@overload
116-
def assertNotAlmostEqual(self, first: float, second: float, *,
117-
msg: Any = ...) -> None: ...
114+
def assertAlmostEqual(self, first: float, second: float,
115+
places: int = ..., msg: Any = ...) -> None: ...
116+
@overload
117+
def assertAlmostEqual(self, first: float, second: float, *,
118+
msg: Any = ..., delta: float = ...) -> None: ...
118119
@overload
119120
def assertNotAlmostEqual(self, first: float, second: float,
120121
places: int = ..., msg: Any = ...) -> None: ...
@@ -173,13 +174,20 @@ class TestCase:
173174
msg: Any = ...) -> _AssertRaisesContext[_E]: ...
174175
def failUnlessAlmostEqual(self, first: float, second: float,
175176
places: int = ..., msg: Any = ...) -> None: ...
176-
def assertAlmostEquals(self, first: float, second: float, places: int = ...,
177+
@overload
178+
def assertAlmostEquals(self, first: float, second: float,
179+
places: int = ..., msg: Any = ...) -> None: ...
180+
@overload
181+
def assertAlmostEquals(self, first: float, second: float, *,
177182
msg: Any = ..., delta: float = ...) -> None: ...
178183
def failIfAlmostEqual(self, first: float, second: float, places: int = ...,
179184
msg: Any = ...) -> None: ...
185+
@overload
180186
def assertNotAlmostEquals(self, first: float, second: float,
181-
places: int = ..., msg: Any = ...,
182-
delta: float = ...) -> None: ...
187+
places: int = ..., msg: Any = ...) -> None: ...
188+
@overload
189+
def assertNotAlmostEquals(self, first: float, second: float, *,
190+
msg: Any = ..., delta: float = ...) -> None: ...
183191
def assertRegexpMatches(self, text: AnyStr, regex: Union[AnyStr, Pattern[AnyStr]],
184192
msg: Any = ...) -> None: ...
185193
@overload

0 commit comments

Comments
 (0)