Better filter typing. Real kwargs types.

Author: hunterhogan

stubs/resampy/resampy/core.pyi

@@ -1,13 +1,20 @@
 from collections.abc import Callable
-from typing import Any
-from typing_extensions import TypeAlias, TypeVar
+from typing import TypedDict, type_check_only
+from typing_extensions import TypeAlias, TypeVar, Unpack
 
 import numpy as np
 
 __all__ = ["resample", "resample_nu"]
 
 _FloatArray = TypeVar("_FloatArray", bound=np.ndarray[tuple[int, ...], np.dtype[np.floating]])
-_FilterType: TypeAlias = str | Callable[..., tuple[np.ndarray[tuple[int, ...], np.dtype[np.floating]], int, float]]
+
+_FilterType: TypeAlias = str | Callable[[int], np.ndarray[tuple[int], np.dtype[np.float64]]]
+
+@type_check_only
+class _FilterKwArgs(TypedDict, total=False):
+    num_zeros: int
+    precision: int
+    rolloff: float
 
 def resample(
     x: _FloatArray,
@@ -16,7 +23,7 @@ def resample(
     axis: int = -1,
     filter: _FilterType = "kaiser_best",
     parallel: bool = False,
-    **kwargs: Any,
+    **kwargs: Unpack[_FilterKwArgs],
 ) -> _FloatArray: ...
 def resample_nu(
     x: _FloatArray,
@@ -25,5 +32,5 @@ def resample_nu(
     axis: int = -1,
     filter: _FilterType = "kaiser_best",
     parallel: bool = False,
-    **kwargs: Any,
+    **kwargs: Unpack[_FilterKwArgs],
 ) -> _FloatArray: ...

stubs/resampy/resampy/filters.pyi

@@ -1,23 +1,33 @@
 from collections.abc import Callable
+from typing import TypedDict, type_check_only
+from typing_extensions import TypeAlias, Unpack
 
 import numpy as np
 
 __all__ = ["get_filter", "clear_cache", "sinc_window"]
 
 # Dictionary to cache loaded filters
-FILTER_CACHE: dict[str, tuple[np.ndarray[tuple[int, ...], np.dtype[np.floating]], int, float]]
+FILTER_CACHE: dict[str, tuple[np.ndarray[tuple[int], np.dtype[np.float64]], int, float]]
 
 # List of filter functions available
 FILTER_FUNCTIONS: list[str]
 
+_FilterType: TypeAlias = str | Callable[[int], np.ndarray[tuple[int], np.dtype[np.float64]]]
+
+@type_check_only
+class _FilterKwArgs(TypedDict, total=False):
+    num_zeros: int
+    precision: int
+    rolloff: float
+
 def sinc_window(
     num_zeros: int = 64,
     precision: int = 9,
-    window: Callable[..., np.ndarray[tuple[int, ...], np.dtype[np.floating]]] | None = None,
+    window: Callable[[int], np.ndarray[tuple[int], np.dtype[np.float64]]] | None = None,
     rolloff: float = 0.945,
-) -> tuple[np.ndarray[tuple[int, ...], np.dtype[np.floating]], int, float]: ...
+) -> tuple[np.ndarray[tuple[int], np.dtype[np.float64]], int, float]: ...
 def get_filter(
-    name_or_function: str | Callable[..., tuple[np.ndarray[tuple[int, ...], np.dtype[np.floating]], int, float]], **kwargs
-) -> tuple[np.ndarray[tuple[int, ...], np.dtype[np.floating]], int, float]: ...
-def load_filter(filter_name: str) -> tuple[np.ndarray[tuple[int, ...], np.dtype[np.floating]], int, float]: ...
+    name_or_function: _FilterType, **kwargs: Unpack[_FilterKwArgs]
+) -> tuple[np.ndarray[tuple[int], np.dtype[np.float64]], int, float]: ...
+def load_filter(filter_name: str) -> tuple[np.ndarray[tuple[int], np.dtype[np.float64]], int, float]: ...
 def clear_cache() -> None: ...