Skip to content

More shards for mypy-primer #19405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025

Conversation

randolf-scholz
Copy link
Contributor

Increases the number of shards by 1 which helps with #19403.

Copy link
Contributor

github-actions bot commented Jul 8, 2025

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's see if this helps.

@JukkaL JukkaL merged commit 40277a1 into python:master Jul 9, 2025
20 checks passed
@randolf-scholz
Copy link
Contributor Author

Oh actually, we did merge hauntsaninja/mypy_primer#190 upstream, which almost doubles the weight of colour and it appears it now occupies a whole shard by itself, so this won't do much anymore.

Here's a sample run: https://github.com/python/mypy/actions/runs/16173327386/job/45652190197?pr=19399

@JukkaL
Copy link
Collaborator

JukkaL commented Jul 10, 2025

I wonder if we should revert this then?

@sterliakov
Copy link
Collaborator

Yes, I think so - the zeroth shard dedicated to colour still dominates the total execution time, other shards complete much earlier. However, if #19408 gets through, this will be good again - halving colour check time will make all six shards ~ equal.

@JukkaL
Copy link
Collaborator

JukkaL commented Jul 16, 2025

Ok, I'll try to review #19408 soon -- if it can be merged soon, we don't need to revert this at all then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants