You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
asm_trampoline.S misses branch protection flags for x86_64 #128605
asm_trampoline.S added here 6d791a9 misses the branch protections offered for the latest x86-64 and aarch64 processors.
For C code the compiler takes care of that however for the assembler files the relevant instructions need to be added manually.
This was discovered by running the annobin-annocheck tool on a Fedora machine:
$ annocheck --hardened libpython3.14.so.1.0
Hardened: libpython3.14.so.1.0: FAIL: cf-protection test because no .note.gnu.property section = no control flow information
Hardened: libpython3.14.so.1.0: FAIL: property-note test because a property note was found but it shows that cf-protection is not enabled
Maybe!
This one always fails though, and for Tier 1 platforms, the policy is to revert and then investigate (unless we have a quick fix). Keeping the buildbots green allows them to catch other bugs.
For x86_64 nope but aarch64 is still an issue unfortunately.
My original intention was to do that on one PR/issue but since x86_64 was fixed I can either close this one and file a new for aarch64 or keep this open till #130864 is resolved.
changed the title [-]asm_trampoline.S misses branch protection flags for x86_64 and aarch64[/-][+]asm_trampoline.S misses branch protection flags for x86_64[/+]on Oct 8, 2025
Activity
gh-128605: Add branch protections for x86_64 in asm_trampoline.S (#12…
pythongh-128605: Add branch protections for x86_64 in asm_trampoline.S (
[3.14] pythongh-128605: Add branch protections for x86_64 in asm_tram…
[3.14] gh-128605: Add branch protections for x86_64 in asm_trampoline…
[3.14] pythongh-128605: Add branch protections for x86_64 in asm_tram…
[3.13] gh-128605: Add branch protections for x86_64 in asm_trampoline…
[3.12] pythongh-128605: Add branch protections for x86_64 in asm_tram…
encukou commentedon Jun 4, 2025
It looks like the backports broke buildbots,see for example:
stratakis commentedon Jun 4, 2025
Isn't it the same failure as #131038 ?
Revert "[3.14] pythongh-128605: Add branch protections for x86_64 in …
encukou commentedon Jun 5, 2025
Maybe!
This one always fails though, and for Tier 1 platforms, the policy is to revert and then investigate (unless we have a quick fix). Keeping the buildbots green allows them to catch other bugs.
9 remaining items
[3.13] pythongh-128605: Add branch protections for x86_64 in asm_tram…
[3.14] gh-128605: Add branch protections for x86_64 in asm_trampoline…
[3.13] gh-128605: Add branch protections for x86_64 in asm_trampoline…
[3.12] gh-128605: Add branch protections for x86_64 in asm_trampolineS (
pythongh-128605: Add branch protections for x86_64 in asm_trampoline.S (
pythongh-128605: Add branch protections for x86_64 in asm_trampoline.S (
encukou commentedon Aug 15, 2025
@stratakis, I don't think there's more to do here (and in #130864). Is that right?
stratakis commentedon Aug 15, 2025
For x86_64 nope but aarch64 is still an issue unfortunately.
My original intention was to do that on one PR/issue but since x86_64 was fixed I can either close this one and file a new for aarch64 or keep this open till #130864 is resolved.
vstinner commentedon Aug 16, 2025
I suggest to open a new issue for aarch64 and limit this one to x86_64.
pythongh-128605: Add branch protections for x86_64 in asm_trampoline.S (
[-]asm_trampoline.S misses branch protection flags for x86_64 and aarch64[/-][+]asm_trampoline.S misses branch protection flags for x86_64[/+]stratakis commentedon Oct 8, 2025
Closing this issue as it's superseded by #139808