gh-133279: Assert with HAS_TARGET in the codegen_addop_j function (#133280)

nybblista · web-flow · commit 20f8ed595d17 · 2025-05-02T13:52:48.000+01:00
diff --git a/Python/codegen.c b/Python/codegen.c
@@ -399,7 +399,7 @@ codegen_addop_j(instr_sequence *seq, location loc,
                 int opcode, jump_target_label target)
 {
     assert(IS_JUMP_TARGET_LABEL(target));
-    assert(OPCODE_HAS_JUMP(opcode) || IS_BLOCK_PUSH_OPCODE(opcode));
+    assert(HAS_TARGET(opcode));
     assert(!IS_ASSEMBLER_OPCODE(opcode));
     return _PyInstructionSequence_Addop(seq, opcode, target.id, loc);
 }

Original file line number	Diff line number	Diff line change
`@@ -399,7 +399,7 @@ codegen_addop_j(instr_sequence *seq, location loc,`
`399`	`399`	`int opcode, jump_target_label target)`
`400`	`400`	`{`
`401`	`401`	`assert(IS_JUMP_TARGET_LABEL(target));`
`402`		`- assert(OPCODE_HAS_JUMP(opcode) \|\| IS_BLOCK_PUSH_OPCODE(opcode));`
	`402`	`+ assert(HAS_TARGET(opcode));`
`403`	`403`	`assert(!IS_ASSEMBLER_OPCODE(opcode));`
`404`	`404`	`return _PyInstructionSequence_Addop(seq, opcode, target.id, loc);`
`405`	`405`	`}`