Merge pull request #37 from dtkav/more_default_checks

validate parameter defaults in swagger 2.0 specs

Author: p1c2u

openapi_spec_validator/validators.py

@@ -299,5 +299,18 @@ def iter_errors(self, parameter):
             for err in self._iter_schema_errors(schema_deref):
                 yield err
 
+        if 'default' in parameter:
+            # only possible in swagger 2.0
+            default = parameter['default']
+            if default is not None:
+                for err in self._iter_value_errors(parameter, default):
+                    yield err
+
+    def _iter_value_errors(self, schema, value):
+        resolver = RefResolver.from_schema(schema)
+        validator = Draft4ExtendedValidatorFactory.from_resolver(resolver)
+        for err in validator(schema, resolver=resolver).iter_errors(value):
+            yield err
+
     def _iter_schema_errors(self, schema):
         return SchemaValidator(self.dereferencer).iter_errors(schema)

tests/integration/conftest.py

@@ -5,7 +5,8 @@
 from six.moves.urllib.parse import urlunparse
 from yaml import safe_load
 
-from openapi_spec_validator import openapi_v3_spec_validator
+from openapi_spec_validator import (openapi_v3_spec_validator,
+                                    openapi_v2_spec_validator)
 from openapi_spec_validator.schemas import read_yaml_file
 
 
@@ -43,3 +44,8 @@ def factory():
 @pytest.fixture
 def validator():
     return openapi_v3_spec_validator
+
+
+@pytest.fixture
+def swagger_validator():
+    return openapi_v2_spec_validator

tests/integration/test_validators.py

@@ -237,3 +237,42 @@ def test_parameter_default_value_wrong_type(self, validator):
         assert errors_list[0].message == (
             "'invaldtype' is not of type 'integer'"
         )
+
+    def test_parameter_default_value_wrong_type_swagger(self,
+                                                        swagger_validator):
+        spec = {
+            'swagger': '2.0',
+            'info': {
+                'title': 'Test Api',
+                'version': '0.0.1',
+            },
+            'paths': {
+                '/test/': {
+                    'get': {
+                        'responses': {
+                            '200': {
+                                'description': 'OK',
+                                'schema': {'type': 'object'},
+                            },
+                        },
+                        'parameters': [
+                            {
+                                'name': 'param1',
+                                'in': 'query',
+                                'type': 'integer',
+                                'default': 'invaldtype',
+                            },
+                        ],
+                    },
+                },
+            },
+        }
+
+        errors = swagger_validator.iter_errors(spec)
+
+        errors_list = list(errors)
+        assert len(errors_list) == 1
+        assert errors_list[0].__class__ == ValidationError
+        assert errors_list[0].message == (
+            "'invaldtype' is not of type 'integer'"
+        )