Address review feedback: fix docstring, trailing whitespace, f-string, install docs, validate_formats

Co-authored-by: p1c2u <1679024+p1c2u@users.noreply.github.com>

Author: Copilot

README.rst

@@ -141,6 +141,13 @@ Allowed values are ``auto`` (default), ``jsonschema``, and
 ``jsonschema-rs``.
 Invalid values raise a warning and fall back to ``auto``.
 
+If you select the ``jsonschema-rs`` backend, make sure the optional
+``jsonschema-rs`` package is installed:
+
+.. code-block:: bash
+
+    pip install jsonschema-rs
+
 Related projects
 ################
 

docs/cli.rst

@@ -73,7 +73,7 @@ Performance note:
    You can tune resolved-path caching with
    ``OPENAPI_SPEC_VALIDATOR_RESOLVED_CACHE_MAXSIZE``.
    Default is ``128``; set ``0`` to disable.
-   
+
    You can also select schema validator backend with
    ``OPENAPI_SPEC_VALIDATOR_SCHEMA_VALIDATOR_BACKEND``
    (``auto``/``jsonschema``/``jsonschema-rs``).

docs/python.rst

@@ -83,5 +83,6 @@ Schema validator backend can be selected with:
    OPENAPI_SPEC_VALIDATOR_SCHEMA_VALIDATOR_BACKEND=jsonschema-rs
 
 Allowed values are ``auto`` (default), ``jsonschema``, and
-``jsonschema-rs``.
+``jsonschema-rs`` (requires the ``jsonschema-rs`` Python package to be
+installed, for example via ``pip install jsonschema-rs``).
 Invalid values raise a warning and fall back to ``auto``.

openapi_spec_validator/schemas/backend/jsonschema_rs.py

@@ -57,7 +57,7 @@ def __init__(self, schema: dict[str, Any], validator: Any):
 
         Args:
             schema: JSON Schema to validate against
-            cls: JSON Schema validator
+            validator: JSON Schema validator
         """
         if not HAS_JSONSCHEMA_RS:
             raise ImportError(
@@ -149,10 +149,7 @@ def create_validator(schema: dict[str, Any]) -> JsonschemaRsValidatorWrapper:
     module = _get_jsonschema_rs_module()
     validator_cls: Any = module.validator_cls_for(schema)
 
-    validator = validator_cls(
-        schema,
-        validate_formats=True,
-    )
+    validator = validator_cls(schema)
     return JsonschemaRsValidatorWrapper(schema, validator=validator)
 
 

tests/bench/runner.py

@@ -309,7 +309,7 @@ def main():
     settings = OpenAPISpecValidatorSettings()
 
     print("Spec schema validator backend selection:")
-    print("  Configured backend mode: " f"{settings.schema_validator_backend}")
+    print(f"  Configured backend mode: {settings.schema_validator_backend}")
     print(f"  Effective backend: {schemas.get_validator_backend()}")
 
     # Benchmark custom specs