Skip to content

Commit d4e9fe4

Browse files
authored
Merge pull request #199 from p1c2u/fix/flask-error-handler-status-fix
Flask error handler status fix
2 parents 912f0af + 15e9c28 commit d4e9fe4

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

openapi_core/contrib/flask/handlers.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,8 @@ def handle(cls, errors):
2222
data = {
2323
'errors': data_errors,
2424
}
25-
status = max(
26-
range(len(data_errors)),
27-
key=lambda idx: data_errors[idx]['status'],
28-
)
25+
data_error_max = max(data_errors, key=lambda x: x['status'])
26+
status = data_error_max['status']
2927
return current_app.response_class(
3028
dumps(data),
3129
status=status,

tests/integration/contrib/flask/test_flask_views.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ def test_invalid_content_type(self, client):
4545

4646
result = client.get('/browse/12/')
4747

48+
assert result.status_code == 415
4849
assert result.json == {
4950
'errors': [
5051
{
@@ -78,6 +79,7 @@ def test_server_error(self, client):
7879
}
7980
]
8081
}
82+
assert result.status_code == 500
8183
assert result.json == expected_data
8284

8385
def test_endpoint_error(self, client):
@@ -97,6 +99,7 @@ def test_endpoint_error(self, client):
9799
}
98100
]
99101
}
102+
assert result.status_code == 400
100103
assert result.json == expected_data
101104

102105
def test_valid(self, client):

0 commit comments

Comments
 (0)