-
Notifications
You must be signed in to change notification settings - Fork 213
Support for workspace symbols #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Correct, Pylsp doesn't support workspace symbols, sorry. |
Is there any plans to implement it? What's you approach to workspace symbols? Do you prefer not to use this feature? |
There are no plans right now, sorry. Maybe Jedi offers this functionality but we haven't checked because there has been little interest for it. |
For the record, I find the workspace symbols feature quite useful. One can always grep the project for |
It seems this is supported by Jedi, so it's feasible here. However, we're swamped with other things, so I don't know when we'll have time to implement it. |
In the README I saw you mentioned that Jedi can provide this function, so does it mean we can use it well now? |
No, we need to implement that functionality in the way expected by the LSP protocol here. |
@ccordoba12 Thanks for clarifying that for us. |
Made a pull request to resolve it. #511 |
Just wanted to politely bump this, I would find it very useful and would love to see an implementation merged. |
Seriously? How the heck an lsp-server doesn't support one of the most important features? Kind of a break-dealer, no? |
OK, which Python LSP server provides workspace symbols? |
basedpyright does. upd: I initially replied from my phone, came to find my laptop to edit my own comment for clarification. Even though my initial question may look like demanding and kind of a dick comment, it was genuine. I don't even write Python day-to-day, I just needed to explore a couple of projects done by another team and I wished for lsp support. I found this project and the number of interesting features implemented in it got me excited. I wasn't even disappointed, but rather confused and surprised by the lack of this feature. Project-wide workspace symbol lookup is one of the most used features for me in other languages I use, so my confusion I believe was justified. I posted my question because I thought maybe, there's an easy workaround. Turns out basedpyright supports the feature, but if it gets implemented here, I would happily use it. Like I said, I have no horses in this race, I'm not actively writing Python - I don't really care for the best and most complete implementation of all the lsp features in a server, but particularly this feature, for me personally is somewhat important. |
I ask because I tried using this package and it complained that
pylsp
does not support this feature. It worked well with pyright though.Does pyright support symbols and pylsp not?
The text was updated successfully, but these errors were encountered: