Skip to content

Support for workspace symbols #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jgarte opened this issue Jul 6, 2022 · 13 comments
Open

Support for workspace symbols #237

jgarte opened this issue Jul 6, 2022 · 13 comments

Comments

@jgarte
Copy link

jgarte commented Jul 6, 2022

I ask because I tried using this package and it complained that pylsp does not support this feature. It worked well with pyright though.

Does pyright support symbols and pylsp not?

@ccordoba12
Copy link
Member

Correct, Pylsp doesn't support workspace symbols, sorry.

@jgarte
Copy link
Author

jgarte commented Jul 7, 2022

Is there any plans to implement it?

@ccordoba12

What's you approach to workspace symbols? Do you prefer not to use this feature?

@ccordoba12
Copy link
Member

There are no plans right now, sorry.

Maybe Jedi offers this functionality but we haven't checked because there has been little interest for it.

@astoff
Copy link

astoff commented Aug 8, 2022

For the record, I find the workspace symbols feature quite useful. One can always grep the project for def something, but that's not as handy. It would also seem relatively straightforward to implement, which gives it a pretty good cost/benefit ratio.

@ccordoba12 ccordoba12 reopened this Aug 8, 2022
@ccordoba12 ccordoba12 changed the title Are workspace symbols supported? Support for workspace symbols Aug 8, 2022
@ccordoba12
Copy link
Member

ccordoba12 commented Aug 8, 2022

It seems this is supported by Jedi, so it's feasible here. However, we're swamped with other things, so I don't know when we'll have time to implement it.

@tristone13th
Copy link

In the README I saw you mentioned that Jedi can provide this function, so does it mean we can use it well now?

@ccordoba12
Copy link
Member

No, we need to implement that functionality in the way expected by the LSP protocol here.

@jgarte
Copy link
Author

jgarte commented Sep 29, 2022

No, we need to implement that functionality in the way expected by the LSP protocol here.

@ccordoba12 Thanks for clarifying that for us.

@eyalk11
Copy link

eyalk11 commented Jan 6, 2024

Made a pull request to resolve it. #511

@Cadair
Copy link

Cadair commented Mar 5, 2025

Just wanted to politely bump this, I would find it very useful and would love to see an implementation merged.

@agzam
Copy link

agzam commented Apr 3, 2025

Seriously? How the heck an lsp-server doesn't support one of the most important features? Kind of a break-dealer, no?

@savchenko
Copy link

OK, which Python LSP server provides workspace symbols?

@agzam
Copy link

agzam commented Apr 19, 2025

OK, which Python LSP server provides workspace symbols?

basedpyright does.

upd: I initially replied from my phone, came to find my laptop to edit my own comment for clarification. Even though my initial question may look like demanding and kind of a dick comment, it was genuine. I don't even write Python day-to-day, I just needed to explore a couple of projects done by another team and I wished for lsp support. I found this project and the number of interesting features implemented in it got me excited. I wasn't even disappointed, but rather confused and surprised by the lack of this feature. Project-wide workspace symbol lookup is one of the most used features for me in other languages I use, so my confusion I believe was justified.

I posted my question because I thought maybe, there's an easy workaround. Turns out basedpyright supports the feature, but if it gets implemented here, I would happily use it. Like I said, I have no horses in this race, I'm not actively writing Python - I don't really care for the best and most complete implementation of all the lsp features in a server, but particularly this feature, for me personally is somewhat important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants