Enable the rest of the ruff rulesets we care about

Author: Julian

noxfile.py

@@ -17,8 +17,8 @@
     path.parent / f"{path.stem}.in" for path in REQUIREMENTS.values()
 ]
 
-SUPPORTED = ["3.8", "3.9", "3.10", "3.11", "3.12", "pypy3.10"]
-LATEST = "3.12"
+SUPPORTED = ["3.8", "3.9", "3.10", "pypy3.10", "3.11", "3.12"]
+LATEST = SUPPORTED[-1]
 
 nox.options.sessions = []
 
@@ -45,7 +45,7 @@ def tests(session):
 
     if session.posargs and session.posargs[0] == "coverage":
         if len(session.posargs) > 1 and session.posargs[1] == "github":
-            github = os.environ["GITHUB_STEP_SUMMARY"]
+            github = Path(os.environ["GITHUB_STEP_SUMMARY"])
         else:
             github = None
 
@@ -54,7 +54,7 @@ def tests(session):
         if github is None:
             session.run("coverage", "report")
         else:
-            with open(github, "a") as summary:
+            with github.open("a") as summary:
                 summary.write("### Coverage\n\n")
                 summary.flush()  # without a flush, output seems out of order.
                 session.run(
@@ -93,7 +93,7 @@ def style(session):
     Check Python code style.
     """
     session.install("ruff")
-    session.run("ruff", "check", ROOT)
+    session.run("ruff", "check", ROOT, __file__)
 
 
 @session()
@@ -102,7 +102,7 @@ def typing(session):
     Check static typing.
     """
     session.install("pyright", ROOT)
-    session.run("pyright", PACKAGE)
+    session.run("pyright", *session.posargs, PACKAGE)
 
 
 @session(tags=["docs"])
@@ -158,7 +158,9 @@ def docs_style(session):
 @session(default=False)
 def requirements(session):
     """
-    Update the project's pinned requirements. Commit the result.
+    Update the project's pinned requirements.
+
+    You should commit the result afterwards.
     """
     session.install("pip-tools")
     for each in REQUIREMENTS_IN:

pyproject.toml

@@ -61,6 +61,7 @@ skip_covered = true
 
 [tool.doc8]
 ignore = [
+    "D000",  # see PyCQA/doc8#125
     "D001",  # one sentence per line, so max length doesn't make sense
 ]
 
@@ -82,51 +83,64 @@ exclude = [
 
 [tool.ruff]
 line-length = 79
-select = [
-  "ANN", "B", "D", "D204", "E", "F", "Q", "RUF", "SIM", "TCH", "UP", "W",
-]
+
+[tool.ruff.lint]
+select = ["ALL"]
 ignore = [
-  # Wat, type annotations for self and cls, why is this a thing?
-  "ANN101",
-  "ANN102",
-  # Private annotations are fine to leave out.
-  "ANN202",
-  # I don't know how to more properly annotate "pass along all arguments".
-  "ANN401",
-  # It's totally OK to call functions for default arguments.
-  "B008",
-  # raise SomeException(...) is fine.
-  "B904",
-  # There's no need for explicit strict, this is simply zip's default behavior.
-  "B905",
-  # It's fine to not have docstrings for magic methods.
-  "D105",
-  # __init__ especially doesn't need a docstring
-  "D107",
-  # This rule makes diffs uglier when expanding docstrings (and it's uglier)
-  "D200",
-  # No blank lines before docstrings.
-  "D203",
-  # Start docstrings on the second line.
-  "D212",
-  # This rule misses sassy docstrings ending with ! or ?.
-  "D400",
-  # Section headers should end with a colon not a newline
-  "D406",
-  # Underlines aren't needed
-  "D407",
-  # Plz spaces after section headers
-  "D412",
-  # Not sure what heuristic this uses, but it seems easy for it to be wrong.
-  "SIM300",
-  # We support 3.8 + 3.9
-  "UP007",
+  "A001",  # It's fine to shadow builtins
+  "A002",
+  "A003",
+  "ARG",  # This is all wrong whenever an interface is involved
+  "ANN",  # Just let the type checker do this
+  "B006",  # Mutable arguments require care but are OK if you don't abuse them
+  "B008",  # It's totally OK to call functions for default arguments.
+  "B904",  # raise SomeException(...) is fine.
+  "B905",  # No need for explicit strict, this is simply zip's default behavior
+  "C408",  # Calling dict is fine when it saves quoting the keys
+  "C901",  # Not really something to focus on
+  "D105",  # It's fine to not have docstrings for magic methods.
+  "D107",  # __init__ especially doesn't need a docstring
+  "D200",  # This rule makes diffs uglier when expanding docstrings
+  "D203",  # No blank lines before docstrings.
+  "D212",  # Start docstrings on the second line.
+  "D400",  # This rule misses sassy docstrings ending with ! or ?
+  "D401",  # This rule is too flaky.
+  "D406",  # Section headers should end with a colon not a newline
+  "D407",  # Underlines aren't needed
+  "D412",  # Plz spaces after section headers
+  "EM101",  # These don't bother me, it's fine there's some duplication.
+  "EM102",
+  "FBT",  # It's worth avoiding boolean args but I don't care to enforce it
+  "FIX",  # Yes thanks, if I could it wouldn't be there
+  "N",  # These naming rules are silly
+  "PLR0912",  # These metrics are fine to be aware of but not to enforce
+  "PLR0913",
+  "PLR0915",
+  "PLW2901",  # Shadowing for loop variables is occasionally fine.
+  "PT006",  # pytest parametrize takes strings as well
+  "PYI025",  # wat, I'm not confused, thanks.
+  "RET502",  # Returning None implicitly is fine
+  "RET503",
+  "RET505",  # These push you to use `if` instead of `elif`, but for no reason
+  "RET506",
+  "RSE102",  # Ha, what, who even knew you could leave the parens off. But no.
+  "SIM300", # Not sure what heuristic this uses, but it's easily incorrect
+  "SLF001",  # Private usage within this package itself is fine
+  "TD",  # These TODO style rules are also silly
+  "UP007",  # We support 3.8 + 3.9
 ]
 
-[tool.ruff.flake8-quotes]
+[tool.ruff.lint.flake8-pytest-style]
+mark-parentheses = false
+
+[tool.ruff.lint.flake8-quotes]
 docstring-quotes = "double"
 
-[tool.ruff.per-file-ignores]
-"noxfile.py" = ["ANN", "D100"]
-"docs/*" = ["ANN", "D"]
-"referencing_loaders/tests/*" = ["ANN", "D", "RUF012"]
+[tool.ruff.lint.isort]
+combine-as-imports = true
+from-first = true
+
+[tool.ruff.lint.per-file-ignores]
+"noxfile.py" = ["ANN", "D100", "S101", "T201"]
+"docs/*" = ["ANN", "D", "INP001"]
+"referencing_loaders/tests/*" = ["ANN", "D", "RUF012", "S", "PLR", "TRY"]